Skip to content

Use config key names in API Center validation errors - #1979

Merged
waldekmastykarz merged 1 commit into
dotnet:mainfrom
waldekmastykarz:fix-1969-api-center-error-casing
Oct 26, 2026
Merged

waldekmastykarz merged 1 commit into
dotnet:mainfrom
waldekmastykarz:fix-1969-api-center-error-casing

Conversation

@waldekmastykarz

Copy link
Copy Markdown
Collaborator

API Center validation errors referenced PascalCase property names (e.g. SubscriptionId) while the config keys are camelCase. Messages now use subscriptionId, resourceGroupName, serviceName, and workspaceName.

Adds tests covering each validation message.

Closes #1969

Error messages now reference camelCase config keys (subscriptionId,
resourceGroupName, serviceName, workspaceName) instead of PascalCase
property names.

Closes dotnet#1969

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2bc25ec3-3ffb-4816-84ef-3f33c88a2c57
Copilot AI balanced review requested due to automatic review settings October 21, 2026 13:55
@waldekmastykarz
waldekmastykarz requested a review from a team as a code owner October 21, 2026 13:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused changes match the requirements and include targeted regression coverage; tests were not executed.

No open issues 🎉

What changed in this PR

Aligns API Center validation errors with camelCase configuration keys, addressing #1969.

Changes:

  • Updates all four validation messages to use config key names.
  • Adds parameterized regression tests for each message.
File Description
DevProxy.Plugins/​ApiCenter/​ApiCenterClient.cs Corrects configuration key names in validation errors.
DevProxy.Integration.Tests/​ApiCenterClientTests.cs Tests all four validation messages.

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused changes match the issue requirements and include coverage for every updated message, with no identified blockers.

No open issues 🎉

Review effort: Balanced

@waldekmastykarz
waldekmastykarz merged commit a7456e1 into dotnet:main Oct 26, 2026
4 checks passed
@waldekmastykarz
waldekmastykarz deleted the fix-1969-api-center-error-casing branch October 26, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API Center validation errors use PascalCase property names

2 participants