Repository navigation
Show defaults for --as-system-proxy and --install-cert in --help - #2089
Open
waldekmastykarz wants to merge 1 commit into
Open
waldekmastykarz wants to merge 1 commit into
waldekmastykarz wants to merge 1 commit into
Conversation
Closes dotnet#2058 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the command-line help clarification.
No open issues 🎉
What changed in this PR
Clarifies Dev Proxy’s command-line help so --as-system-proxy and --install-cert no longer appear to be opt-in switches. Parsing behavior is unchanged.
Changes:
- Shows
true|falsearguments and documents that both options default totrue. - Clarifies the option descriptions and links to the system proxy documentation.
| File | Description |
|---|---|
| DevProxy/Commands/DevProxyCommand.cs | Updates help descriptions and argument labels for both boolean options. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devproxy --helpmade--as-system-proxyand--install-certlook like opt-in switches, but both default totrue. This change shows the boolean argument and the default in the help text, and links to the system proxy docs:Only the help text changes. Parsing is the same, so bare
--as-system-proxystill meanstrue.Resolves #2058