Skip to content

chore(deps)(deps): bump naga from 29.0.4 to 30.0.1 - #42

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/cargo/naga-30.0.1
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/cargo/naga-30.0.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 13, 2026

Copy link
Copy Markdown

Bumps naga from 29.0.4 to 30.0.1.

Release notes

Sourced from naga's releases.

v30.0.1

Bug Fixes

Vulkan

  • Stop passing an un-waited fence to vkAcquireNextImageKHR on non-Windows platforms, which triggered VUID-vkAcquireNextImageKHR-fence-10066 validation errors every frame since v30.0.0. By @​ErichDonGubler in #9855.

Metal

WebGPU

  • Upgrade vendored WebGPU bindings and wasm-bindgen to 0.2.127. This fixes a panic “can't access property "info", arg0 is null” when using the WebGPU backend and requestAdapter() fails. By @​beicause in #10034, backported in #10105.

v30.0.0

Major changes

Optional vertex buffer slots

This allows gaps in VertexState's buffers and adds support for unbinding vertex buffers, bringing us in compliance with the WebGPU spec. As a result of this, VertexState's buffers field now has type of &[Option<VertexBufferLayout>]. To migrate, wrap vertex buffer layouts in Some:

  let vertex_state = wgpu::VertexState {
      module: &vs_module,
      entry_point: Some("vs_main"),
      compilation_options: wgpu::PipelineCompilationOptions::default(),
      buffers: &[
-         &vertex_buffer_layout
+         Some(&vertex_buffer_layout)
      ],
  };

By @​teoxoy in #9351.

Integer shader I/O no longer defaults to @interpolate(flat)

To align with the shading language specifications, naga no longer assumes that integer-typed shader I/O should have flat interpolation, i.e., should not be interpolated. Even though flat interpolation is the only choice for integer I/O, it must be still specified explicitly.

WGSL:

 struct FragmentInput {
     @location(0) tex_coord: vec2<f32>,
-    @location(1) index: i32,
+    @location(1) @interpolate(flat) index: i32,
 }

... (truncated)

Changelog

Sourced from naga's changelog.

v30.0.1 (2026-08-21)

Bug Fixes

Vulkan

  • Stop passing an un-waited fence to vkAcquireNextImageKHR on non-Windows platforms, which triggered VUID-vkAcquireNextImageKHR-fence-10066 validation errors every frame since v30.0.0. By @​ErichDonGubler in #9855.

Metal

WebGPU

  • Upgrade vendored WebGPU bindings and wasm-bindgen to 0.2.127. This fixes a panic “can't access property "info", arg0 is null” when using the WebGPU backend and requestAdapter() fails. By @​beicause in #10034, backported in #10105.

v30.0.0 (2026-07-01)

Major changes

Optional vertex buffer slots

This allows gaps in VertexState's buffers and adds support for unbinding vertex buffers, bringing us in compliance with the WebGPU spec. As a result of this, VertexState's buffers field now has type of &[Option<VertexBufferLayout>]. To migrate, wrap vertex buffer layouts in Some:

  let vertex_state = wgpu::VertexState {
      module: &vs_module,
      entry_point: Some("vs_main"),
      compilation_options: wgpu::PipelineCompilationOptions::default(),
      buffers: &[
-         &vertex_buffer_layout
+         Some(&vertex_buffer_layout)
      ],
  };

By @​teoxoy in #9351.

Integer shader I/O no longer defaults to @interpolate(flat)

To align with the shading language specifications, naga no longer assumes that integer-typed shader I/O should have flat interpolation, i.e., should not be interpolated. Even though flat interpolation is the only choice for integer I/O, it must be still specified explicitly.

WGSL:

 struct FragmentInput {
     @location(0) tex_coord: vec2<f32>,
-    @location(1) index: i32,
+    @location(1) @interpolate(flat) index: i32,
 }
</tr></table> 

... (truncated)

Commits
  • 40f4a34 Release v30.0.1
  • 5e1084c fix(metal): Resolve some color space constants dynamically (#9819)
  • 8bc5e2b Backport "Re-vendor WebGPU bindings (#10034)" to v30. (#10105)
  • 42738aa backport: fix: use vk::Fence::null on non-Windows swapchain (#9918)
  • 1464540 Remove example warning
  • 8bf3e5f Update to v30 (#9790)
  • aa2b790 [core] filter native-only features and limits if
  • 2ea3a1d [vulkan] advertise DownlevelFlags::SURFACE_VIEW_FORMATS if `VK_KHR_swapchai...
  • 69e66d8 add DENO_WEBGPU_STRICT_COMPLIANCE and set it for the CTS job
  • 995ee7b add Limits::max_buffers_and_acceleration_structures_per_shader_stage
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [naga](https://github.com/gfx-rs/wgpu) from 29.0.4 to 30.0.1.
- [Release notes](https://github.com/gfx-rs/wgpu/releases)
- [Changelog](https://github.com/gfx-rs/wgpu/blob/trunk/CHANGELOG.md)
- [Commits](gfx-rs/wgpu@v29.0.4...v30.0.1)

---
updated-dependencies:
- dependency-name: naga
  dependency-version: 30.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @github

dependabot Bot commented on behalf of github Oct 13, 2026

Copy link
Copy Markdown
Author

Labels

The following labels could not be found: dependencies, rust. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 8be54411-6286-49a9-8de9-9e7e3c2e3044
📥 Commits

Reviewing files that changed from the base of the PR and between 4be2a4e and 7d543cf.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • crates/rusty2600-frontend/Cargo.toml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated internal development tooling for frontend shader workflows.
    • This update does not change visible features, controls, rendering behavior, or user workflows. No changes to the app’s public interfaces or end-user functionality are included.

The frontend crate’s dev dependency on naga moves from version 29 to version 30. The wgsl-in feature remains enabled.

Changes: Frontend naga Update

Layer / File(s) Summary
Update naga dev dependency
crates/rusty2600-frontend/Cargo.toml
The naga dev dependency moves from version 29 to version 30. The wgsl-in feature remains enabled.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 7d543

The dependency update is consistent, and no concrete frontend regression is established. Confirm the frontend tests in normal CI; the attempted run stopped during toolchain and index setup.

### Architecture Summary

Architecture risk: 🔵 Low · up to 7d543

The change affects 1 system.

Changed systems: crates

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — crates (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in crates/rusty2600-frontend/Cargo.toml: The dev dependency naga moves from version 29 to 30; wgsl-in remains enabled.
Pre-merge checks · Passed 5
Passed Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the dependency upgrade from naga 29.0.4 to 30.0.1.
Description check Passed The description directly explains the naga upgrade and includes relevant release notes and compatibility details.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednaga@​30.0.17210093100100

View full report

@github-actions

Copy link
Copy Markdown

Antigravity review (Gemini via Ultra)

This PR bumps the naga dev-dependency in crates/rusty2600-frontend/Cargo.toml from 29 to 30 and updates Cargo.lock to pull naga 30.0.1.

Blocking issues

  • Test validation version mismatch causes false-positive shader verification: As documented in crates/rusty2600-frontend/Cargo.toml and test harnesses such as crates/rusty2600-frontend/src/gfx.rs, naga is explicitly required to match the exact version used by wgpu at runtime so shader errors fail CI rather than aborting the application. In Cargo.lock, runtime dependencies (wgpu-core, wgpu-hal, etc.) remain on naga 29.0.4. Upgrading the dev-dependency to naga 30.0.1 invalidates this correctness contract: WGSL syntax or capabilities valid in Naga 30 could pass CI tests but fail or abort at runtime under Naga 29.

Suggestions

  • Reject or close this PR until wgpu can be updated to version 30 in tandem across the workspace (a bump previously deferred because egui-wgpu 0.35 still pins wgpu 29, as recorded in CHANGELOG.md).
  • Add an ignore rule in your automated dependency management configuration (e.g., Dependabot) for naga so it is not updated independently of wgpu.

Nitpicks

  • The PR title contains duplicated scope tokens (chore(deps)(deps):); conventional commits expect a single scope (chore(deps):).

Automated first-pass review by agy on a self-hosted runner -- not a human review.

@doublegate

Copy link
Copy Markdown
Owner

Bot Review Adjudication (Antigravity + CodeRabbit):

  • Addressed Antigravity's blocking finding: naga 30.0.1 is upgraded in lockstep with wgpu 30.0.1 (and grouped in .github/dependabot.yml) in the consolidated dependency PR so offline WGSL shader validation in tests matches the runtime wgpu shader compiler.

@doublegate

Copy link
Copy Markdown
Owner

Superseded by consolidated dependency PR #49.

@doublegate doublegate closed this Oct 20, 2026
@dependabot @github

dependabot Bot commented on behalf of github Oct 20, 2026

Copy link
Copy Markdown
Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/cargo/naga-30.0.1 branch October 20, 2026 05:07
doublegate added a commit that referenced this pull request Oct 20, 2026
… Rust 1.99) (#49)

* chore(deps): consolidate dependency bumps (egui 0.37, wgpu 30, zip 9, Rust 1.99)

- Bump pinned toolchain and workspace MSRV from Rust 1.96 to Rust 1.99 across rust-toolchain.toml, Cargo.toml, workflows, and docs
- Upgrade egui, egui-winit, and egui-wgpu to 0.37.0 (enabling monochrome_emoji_fonts to preserve default UI and debugger icon fonts) and migrate textures_delta and Id::unique call sites
- Upgrade wgpu and naga to 30.0.1 across native, wasm32, and dev-dependencies and migrate RequestAdapterOptions, SurfaceConfiguration, and Queue::present
- Upgrade zip to 9.0.5 and migrate ZipFile::name() Result return in rom_archive.rs
- Upgrade wasm-bindgen (0.2.129), wasm-bindgen-futures (0.4.79), js-sys (0.3.106), web-sys (0.3.106), and transitive crates
- Fix Rust 1.99 clippy lints (assert_is_empty, chunks_exact_to_as_chunks, suboptimal_flops) and dependabot.yml commit-message scope duplication

Supersedes #42, #43, #44, #45, #46, #47, #48.

* fix(frontend): consume egui texture deltas in scripting tests and skip undecodable zip names

- Call full_output.drop_without_applying_deltas() in scripting overlay tests for egui 0.37 debug assertion compatibility
- Skip non-decodable entry names and check ROM_EXTENSIONS before allocating owned String in rom_archive::extract_first_rom
- Replace [] as [T; 0] slice assertions with .as_slice(), &[] and update wgpu version note in docs/frontend.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant