Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the same 18
:has()regression cases used for the v2 backport to the v3 unit suite. They cover invalid arguments on empty and populated queries, nested:has()inside strict and forgiving lists, wildcard namespaces, quoted and escaped text, repeated queries, and configuration changes across the installed DOM selector APIs.The existing v3 runtime already passes these cases, so this PR changes tests only and removes
docs/repo/testing/has-comparison.md. No new backport report files are committed.Validation:
has-validationsuite and existinglogical-validationsuite pass.pnpm run checkpasses, including formatting, lint, and TypeScript validation.:has()pages pass on both v3 and the patched v2 source. WPT revision:fd983776a7cd19ebcda7a2bcb69c74330ee5d8c9, Chrome for Testing 154.0.8037.0. Parsing pages use the existing DOM selector-validity helper without result filtering. The separate:has-slottedpseudo-class is excluded from this total.