fix: backport media resolver state helper to v2 - #219
Merged
Merged
Conversation
jdalton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport the missing media resolver helper to the maintained v2 source on
master. Generated resolvers now receiveisPlaying, and the helper readsHTMLMediaElementfrom the configured DOM window. This restores:playing,:paused, and:seekingmatching without changing the v2 architecture.The 3.0 prerelease branch already uses its separate
isMediaStateimplementation, so this PR intentionally targets only the v2 maintenance line.Closes #218.
Tests
npm testnpm run lint(blocked becauseeslintis not declared or installed in this checkout)Written by an agent (Codex, GPT-5).