[drakulavich]

Closes #149, closes #151.

What

• login --path <directory> (or OURA_TOKEN_PATH naming one) is BAD_ARGS: <path> is a directory., with <path>/.oura-token as the example in the hint. writeToken catches EISDIR and rethrows every other error unchanged. (login --token x --path <existing directory> fails with a raw EISDIR and no hint #149)
• --db or OURA_DB_PATH naming a directory is DB_ERROR: Cannot open database <path>: it is a directory., hint Point --db / OURA_DB_PATH at a file, such as <path>/oura.db. openDatabase checks before it opens, outside the try block, so the permissions hint no longer replaces it. doctor shows the same fix, because it passes the open error's hint through. (OURA_DB_PATH pointing at a directory gets the permissions hint instead of "this is a directory" #151)
• CLAUDE.md: the clause about login letting a raw EISDIR through is gone, since a test now covers it.

Why

Both reproduced on main (0.9.1 sources):

• login --token x --path <dir> printed error: EISDIR: illegal operation on a directory, open '<dir>', exit 1, no hint.
• OURA_DB_PATH=<dir> oura-cli db today gave unable to open database file with the hint about write permissions on the file and its directory.

How checked

• New tests: src/commands/login.test.ts (writeToken into a temp dir) and src/db/open.test.ts (openDatabase on a temp dir). Each asserts code, message and hint exactly.
• Mutations, one per issue, each reverted after one run of the test file:
  • login --token x --path <existing directory> fails with a raw EISDIR and no hint #149: if ((err as NodeJS.ErrnoException).code !== 'EISDIR') throw err; → throw err; in login.ts: 1 of 5 fails (the new test).
  • OURA_DB_PATH pointing at a directory gets the permissions hint instead of "this is a directory" #151: the directory check if (dbPath !== ':memory:' && existsSync(dbPath) && statSync(dbPath).isDirectory()) { → if (false) { in open.ts: 1 of 26 fails (the new test).
• bun run check: typecheck, Biome, Knip clean; 713 tests pass.
• Codex review: Approve, no findings (report in the first comment).

🤖 Generated with Claude Code

https://claude.ai/code/session_018qh9xqviBHYmzVtmQWSKqA

[drakulavich]

Codex review (gpt-6-luna, final, ebcf1cc..4463700):

Reviewed c20fd75^..4463700. The directory checks and error hints match the brief; I found no Critical or Required issues.

The touched tests passed: 31 tests across src/commands/login.test.ts and src/db/open.test.ts.

Simplification: not needed

Verdict: Approve

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge, with two non-blocking findings from the previous review still open.

Findings

1.  Correct hints fail Windows tests ▶
2.  File checks bypass database errors ▶

Summary

The PR gives clearer errors when a token or database path names a directory.

• Login points out when its token path is a directory.
• Database paths that name directories get a file-path suggestion.

_{Reviews (2) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile}

[greptile-apps]

Correct hints fail Windows tests

The new tests expect / before the example filename, but both functions build their hints with join, which uses backslashes on Windows. These exact checks fail even when the returned hint is correct. Use join(target, 'oura.db') here and join(dir, '.oura-token') in src/commands/login.test.ts.

[greptile-apps]

File checks bypass database errors

statSync now runs outside the error wrapper. If another process removes the database after existsSync succeeds—for example, while rebuilding the cache—statSync throws a raw file error. Commands then report UNKNOWN with exit code 1 instead of DB_ERROR with exit code 4, and doctor loses the hint. Keep file checks inside the wrapper while preserving the directory-specific CliError.