[Kit]: Skip commutativity check on drizzle-kit migrate - #6138
Open
MHJahanbakhsh wants to merge 1 commit into
Open
[Kit]: Skip commutativity check on drizzle-kit migrate#6138MHJahanbakhsh wants to merge 1 commit into
MHJahanbakhsh wants to merge 1 commit into
Conversation
migrate ran the same snapshot commutativity analysis as generate/check on every invocation, which can take minutes on large migration histories even when nothing is pending. Keep the check on generate and drizzle-kit check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drizzle-kit migrate. The check still runs ongenerate(where it can prevent conflicting snapshots) and ondrizzle-kit check(where users opt into it).--ignore-conflictsremains accepted onmigratefor backward compatibility.Fixes #5777
Test plan
drizzle-kit migrateno longer runscheckHandler/detectNonCommutativebefore applying migrationsdrizzle-kit generatestill runs the commutativity checkdrizzle-kit checkstill runs the commutativity checkdrizzle-kit migrate --ignore-conflictsstill parses