fix(kit): do not infer 1-1 from a partial unique index - #6146
Open
official-burak wants to merge 1 commit into
Open
fix(kit): do not infer 1-1 from a partial unique index#6146official-burak wants to merge 1 commit into
official-burak wants to merge 1 commit into
Conversation
Partial UNIQUE INDEX ... WHERE is unique only for a subset of rows, so drizzle-kit pull should not promote the parent side of that FK to r.one. Also match unique columns against the raw FK names so camelCase pull still detects a true full unique.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drizzle-kit pulltreatedUNIQUE INDEX ... WHERE ...as a full unique when deciding one-to-one vs one-to-many. A partial unique only constrains a subset of rows (e.g. one active document per user), so the parent side of that FK is still many.This filters unique indexes that have a
wherepredicate out of 1-1 inference for Postgres, SQLite, and Cockroach, and matches unique columns against the raw FK names so camelCase pull still sees a real full unique.Fixes #6145
Test plan
pnpm exec vitest run tests/postgres/relations-pull.test.ts— 3 passeduniquesstill contains['user_id'])drizzle-kit pullagainst the SQL in [BUG]: drizzle-kit pull infers a one-to-one relation from a PARTIAL unique index #6145 generatesr.many.documents()onusers