Skip to content

Fix nested partial select nullification on left join - #6160

Draft
cjnegao11-cmyk wants to merge 1 commit into
drizzle-team:mainfrom
cjnegao11-cmyk:fix-1603-nested-left-join-null
Draft

Fix nested partial select nullification on left join#6160
cjnegao11-cmyk wants to merge 1 commit into
drizzle-team:mainfrom
cjnegao11-cmyk:fix-1603-nested-left-join-null

Conversation

@cjnegao11-cmyk

Copy link
Copy Markdown

Summary

  • prevent nested partial-select objects from being nullified when a later column from the same joined table is non-null
  • add unit coverage for mixed null/non-null joined fields and all-null joined fields
  • add a PostgreSQL integration regression test for the reported left join scenario

Validation

  • pnpm exec vitest run tests/utils.test.ts → 2 passed
  • pnpm exec tsc --noEmit --pretty false -p tests/tsconfig.json → passed
  • package test suite executed 544 tests successfully; 2 SQLite casing suites could not start locally because the native better-sqlite3 binding was unavailable on Windows

Closes #1603

@cjnegao11-cmyk

cjnegao11-cmyk commented Aug 21, 2026

Copy link
Copy Markdown
Author

This PR addresses #1603 by updating the nested result nullification logic and adding regression coverage for the reported left join case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Nested Partial Select returns null on left join if first column value is null

1 participant