Fix nested partial select nullification on left join - #6160
Draft
cjnegao11-cmyk wants to merge 1 commit into
Draft
Fix nested partial select nullification on left join#6160cjnegao11-cmyk wants to merge 1 commit into
cjnegao11-cmyk wants to merge 1 commit into
Conversation
Author
|
This PR addresses #1603 by updating the nested result nullification logic and adding regression coverage for the reported left join case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm exec vitest run tests/utils.test.ts→ 2 passedpnpm exec tsc --noEmit --pretty false -p tests/tsconfig.json→ passedbetter-sqlite3binding was unavailable on WindowsCloses #1603