Repository navigation
fix(web): open the browser only once serve is listening; close remaining coverage gaps - #144
Merged
Merged
Conversation
…an early Ctrl+C Start opened the browser after a blind 500ms, even when the port was taken and the server never came up. It now listens first and opens the browser only on success. serve's Ctrl+C handler could call Shutdown before Start had built the http.Server (nil dereference) and read it unsynchronised; both are now guarded, and an early Shutdown makes Start return.
… auto, export and send fill runs against a stub browser (formBrowser seam) so its CAPTCHA/submit/ fill handling is tested without Chrome; auto's wait between cycles is a var so the loop can be ended; serve and monitor --watch are stopped with a real SIGINT. update-brokers --check returns an error instead of calling os.Exit(1) mid-command - the exit code is still 1. cmd/eraser 89% -> 95.5%, internal/web 91% -> 94.5%.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serveopened the browser after a blind 500ms, even when the port was taken. It now listens first and opens the browser only on success. An early Ctrl+C could also call Shutdown on a nil server and panic. Both are now guarded.formBrowserseam) and the auto loop's wait is a var. serve andmonitor --watchare stopped with a real SIGINT (--watchis!racebecause of the go-imap race).update-brokers --checkreturns an error instead of callingos.Exit(1), and the exit code is unchanged.BEGIN_COMMIT_OVERRIDE
fix(web): open the browser only once serve is listening; no panic on an early Ctrl+C
test(cli): close the remaining coverage gaps in serve, fill, monitor, auto, export and send
END_COMMIT_OVERRIDE