Repository navigation
test: share the fake IMAP and SMTP servers across packages - #149
Merged
Merged
Conversation
internal/imaptest and internal/smtptest replace three copies of the go-imap memory-server setup and two fake SMTP relays (Go can't import _test.go helpers across packages). Also drops a dead leftover in cmd_gaps_test, reads captured stdout with io.ReadAll and finds a free port with net.Listen. Codecov ignores the two helper packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/imaptest and internal/smtptest replace three copies of the
go-imap memory-server setup and two fake SMTP relays (Go can't import
_test.go helpers across packages). Also drops a dead leftover in
cmd_gaps_test, reads captured stdout with io.ReadAll and finds a free
port with net.Listen. Codecov ignores the two helper packages.