perf: cross-compile arm64 instead of building under QEMU - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The builder stage now runs on the runner's own arch (
FROM --platform=$BUILDPLATFORM) and Go cross-compiles withGOOS=$TARGETOS GOARCH=$TARGETARCH. arm64 no longer builds under QEMU. This is the same pattern momentarr uses, where builds take ~1 min; this repo's builds take ~5 min today.Checked locally: building
--platform linux/amd64on an arm64 Mac produces an image that starts and exits with the expected config error.