chore(dashboard): plot lowest and highest rate-limit budget - #28
Merged
Merged
Conversation
…f one line per window A line per window gives a new series every hour (its reset time is the label), so a 24h view showed ~48 short segments. Two stable lines across whatever windows exist read better; per-window detail stays in the metric.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rate-limit-over-time panel drew one line per
github_rate_limit_window_remainingseries. Each series is labelled with its window's reset time, so it lives for at most an hour. A 24h view would have shown ~48 short segments and a legend to match.It now plots two stable lines across whatever windows exist at each moment:
min(...), the one that runs out first, which equalsgithub_rate_limit_remaining;max(...).With one window the two lines overlap. Per-window detail stays in the metric for Explore.
The dashboard uid is unchanged. This is dashboard only and cuts no release. The cluster copy is updated in the cluster repo.