chore(dashboard): size the runs-by-conclusion bars to the time range - #29
Merged
Merged
Conversation
A fixed 1d step lines points up at 00:00 UTC, so the panel showed nothing for most of a day and only a bar or two on the default 24h view. Use $__interval with a 1h floor and ~30 bars instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runs panel used
increase(...[1d])with a 1-day step. Prometheus lines those points up at 00:00 UTC, so the panel showed No data until the first midnight after a deploy, and only one or two bars on the default 24h view.It now uses
[$__interval]with a 1h minimum andmaxDataPoints: 30, so there are about 30 bars whatever the range: hourly on 24h, ~6h on 7d, daily on 30d. The title drops "per day", and the README wording follows. Dashboard only, so no release.