fix(web): wire availableBalance into DepositTab to prevent failed deposits (#1063)

[Yasir-TechGuy]

Summary

• Fixes the dead code path in DepositTab ([Bug] The over-balance deposit guard never runs in the app #1063): Previously, VaultPanel rendered <DepositTab /> without passing the availableBalance prop. Because the prop was optional, DepositTab silently skipped the over-balance validation, allowing users to submit deposits larger than their wallet balance.
• Added useUsdcBalance hook: Fetches the connected wallet's USDC balance directly from Horizon using fetchBalances — the exact same source used by useTrustlines for the deposit's trustline check.
• Wired the balance into the UI: VaultPanel now consumes useUsdcBalance and passes the value into <DepositTab availableBalance={...} />.
• Fail-open on data errors: If the Horizon fetch fails or the wallet has no USDC trustline, the hook returns undefined. This preserves the existing optional behavior so transient network errors don't permanently lock users out of deposits.
• Added VaultPanel-level regression tests: Ensures that if a future developer removes the availableBalance prop, the test suite fails. The tests explicitly assert that the exceedsBalance error is shown and the submit button is disabled when the wallet balance is lower than the typed amount.

Test plan

• pnpm lint && pnpm typecheck && pnpm test pass locally
• Verified UI behavior manually:
  • With mocked balance = 10 USDC, typing 100 USDC shows vaultPanel.validation.exceedsBalance and disables vault-deposit-submit.
  • With mocked balance = 100 USDC, typing 50 USDC leaves submit enabled.

Closes #1063

[vercel]

Someone is attempting to deploy a commit to the Collins' projects Team on Vercel.

A member of the Team first needs to authorize it.

[drips-wave]

@Yasir-TechGuy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[Yasir-TechGuy]

Hi @collinsezedike Please check it out

[collinsezedike]

@Yasir-TechGuy, thank you for the fix. The guard is wired correctly and the VaultPanel test exercises it, but the branch cannot merge as it stands.

The Commit Messages check fails: the commit subject fix(web): wire availableBalance into DepositTab to prevent failed deposits is 74 characters and the limit is 72. Amend or squash it to a shorter subject with no issue reference, for example fix(web): wire availableBalance into the deposit guard.

There is one correctness note on the hook inline.

[Yasir-TechGuy]

Thanks @collinsezedike — both points addressed in the latest push (1dde25e):

1. Commit subject shortened to fix(web): wire availableBalance into the deposit guard (54 chars, no issue suffix). Body is just Closes #1063.

2. Balance is refetched after a successful deposit. useUsdcBalance now returns { balance, refetch }. Internally, refetch() bumps a nonce that's in the effect's dependency array, so calling it re-runs the Horizon fetch. VaultPanel.executeDeposit calls refetchBalance() inside the if (ok) branch, so any successful deposit immediately updates the guard.

   Added two tests in VaultPanel.test.tsx:

   • calls refetchBalance() when the deposit succeeds — asserts refetch fires exactly once after deposit() resolves true.
   • does not refetch when the deposit fails — asserts refetch is not called when deposit() resolves false.

All four local checks pass: format, lint, typecheck, tests (359/359). CI should be green on the new SHA.

Thanks for catching the stale-balance bug — that would have been an on-chain revert we didn't prevent.

[Yasir-TechGuy]

Please @collinsezedike i have also applied to work on the last 2 unassiged issue in your repo, please kindly assign them to me, i will do a great job

[collinsezedike]

@Yasir-TechGuy thank you for the contribution. There are more open issues if you would like to keep going.

[Yasir-TechGuy]

@Yasir-TechGuy thank you for the contribution. There are more open issues if you would like to keep going.

@collinsezedike Yes I would like to. Please kindly assign the unassigned issues to me. I have applied for them already 🙏