Skip to content

fix(ci): add snapshot keeper to deploy-external-pinger.sh - #1120

Open
solaawojobi00-bit wants to merge 1 commit into
drydocs:mainfrom
solaawojobi00-bit:fix/issue-1104-pinger-snapshot-keeper
Open

solaawojobi00-bit wants to merge 1 commit into
drydocs:mainfrom
solaawojobi00-bit:fix/issue-1104-pinger-snapshot-keeper

Conversation

@solaawojobi00-bit

Copy link
Copy Markdown
Contributor

fix(ci): add snapshot keeper to deploy-external-pinger.sh

Problem

scripts/deploy-external-pinger.sh configures and verifies only three of the four keepers that .github/workflows/keepers.yml schedules. The snapshot keeper is omitted, so once the external driver replaces GitHub cron it is left unscheduled.

Keeper keepers.yml Script (before) Script (after)
alert */5 * * * * yes yes
accrue */15 * * * * yes yes
rebalance 0 * * * * yes yes
snapshot 0 * * * * no yes

Solution

Add snapshot with the same hourly cadence as the workflow, to the header comment, the printed config and the --verify loop.

Changes

  • scripts/deploy-external-pinger.sh: add the snapshot job (0 * * * *) to the header comment and printed config, add snapshot to the --verify loop, and change "three" to "four" in the wording.

Regression Tests

Acceptance criterion Check
Printed config and --verify loop cover snapshot diff; bash -n
Cadence matches keepers.yml 0 * * * * in both

Testing

bash -n scripts/deploy-external-pinger.sh
(no output, exit 0)

--verify was not run, since it needs a live API and CRON_SECRET.

Notes for Reviewers

Related: #973, #796.

Closes #1104

@vercel

vercel Bot commented Oct 18, 2026

Copy link
Copy Markdown

@solaawojobi00-bit is attempting to deploy a commit to the Collins' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Oct 18, 2026

Copy link
Copy Markdown

@solaawojobi00-bit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] deploy-external-pinger.sh omits the snapshot keeper

1 participant