Repository navigation
fix(ci): add snapshot keeper to deploy-external-pinger.sh - #1120
Open
solaawojobi00-bit wants to merge 1 commit into
Open
solaawojobi00-bit wants to merge 1 commit into
solaawojobi00-bit wants to merge 1 commit into
Conversation
|
@solaawojobi00-bit is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@solaawojobi00-bit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ci): add snapshot keeper to deploy-external-pinger.sh
Problem
scripts/deploy-external-pinger.shconfigures and verifies only three of the four keepers that.github/workflows/keepers.ymlschedules. Thesnapshotkeeper is omitted, so once the external driver replaces GitHub cron it is left unscheduled.*/5 * * * **/15 * * * *0 * * * *0 * * * *Solution
Add
snapshotwith the same hourly cadence as the workflow, to the header comment, the printed config and the--verifyloop.Changes
scripts/deploy-external-pinger.sh: add thesnapshotjob (0 * * * *) to the header comment and printed config, addsnapshotto the--verifyloop, and change "three" to "four" in the wording.Regression Tests
--verifyloop coversnapshotbash -nkeepers.yml0 * * * *in bothTesting
--verifywas not run, since it needs a live API andCRON_SECRET.Notes for Reviewers
Related: #973, #796.
Closes #1104