Skip to content

fix(sdk): retry failed alerts from the same ledger - #1123

Merged
collinsezedike merged 1 commit into
drydocs:mainfrom
svllvsx:fix/alert-same-ledger-retry
Oct 18, 2026
Merged

collinsezedike merged 1 commit into
drydocs:mainfrom
svllvsx:fix/alert-same-ledger-retry

Conversation

@svllvsx

@svllvsx svllvsx commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep the cursor at or before a failed alert's ledger, even when an earlier action in that ledger succeeded or was a skipped accept.
  • Add two-run regressions sharing the same store, plus successful same-ledger batches and different-ledger failure coverage.
  • Preserve the numeric cursor format. Replaying a failed ledger can repeat an earlier successful alert; the documentation now makes that trade-off explicit.

Test plan

  • pnpm lint && pnpm typecheck && pnpm test pass locally (1,896 tests on current main).
  • pnpm format:check, pnpm typecheck:api, and pnpm coverage pass.
  • All 17 alert-keeper tests pass. Both new same-ledger regression cases fail against the original code and pass with the fix.

Closes #1060

@vercel

vercel Bot commented Oct 18, 2026

Copy link
Copy Markdown

@svllvsx is attempting to deploy a commit to the Collins' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Oct 18, 2026

Copy link
Copy Markdown

@svllvsx Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@svllvsx
svllvsx marked this pull request as ready for review October 18, 2026 04:34

@collinsezedike collinsezedike left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svllvsx thank you for the contribution. There are more open issues if you would like to keep going.

@collinsezedike
collinsezedike merged commit 122319e into drydocs:main Oct 18, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] The alert keeper can skip a same-ledger alert permanently

2 participants