Skip to content

fix(sdk): support prefixed Upstash store credentials - #1124

Merged
collinsezedike merged 1 commit into
drydocs:mainfrom
svllvsx:fix/upstash-env-fallbacks-1057
Oct 18, 2026
Merged

collinsezedike merged 1 commit into
drydocs:mainfrom
svllvsx:fix/upstash-env-fallbacks-1057

Conversation

@svllvsx

@svllvsx svllvsx commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Accept the store-prefixed Upstash URL and token in the keeper heartbeat and position snapshot loaders, matching the sibling stores.
  • Preserve unprefixed precedence, trimming, and in-memory fallback behavior, including explicitly blank credentials.
  • Add isolated regression coverage for both naming schemes, independently missing values, precedence, and local/deployed fallback logging with mocked Redis requests.

Test plan

  • pnpm lint && pnpm typecheck && pnpm test pass locally (1,927 tests on current main).
  • pnpm format:check, pnpm typecheck:api, and pnpm coverage pass.
  • All 73 heartbeat/snapshot tests pass. Six regression cases fail against the original loaders and pass with the fix.
  • Vercel build and API-local build pass.

Closes #1057

@vercel

vercel Bot commented Oct 18, 2026

Copy link
Copy Markdown

@svllvsx is attempting to deploy a commit to the Collins' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Oct 18, 2026

Copy link
Copy Markdown

@svllvsx Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@collinsezedike collinsezedike left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svllvsx thank you for the contribution. There are more open issues if you would like to keep going.

@collinsezedike
collinsezedike merged commit afcd0bf into drydocs:main Oct 18, 2026
10 of 11 checks passed
@collinsezedike

Copy link
Copy Markdown
Collaborator

@svllvsx thank you again for getting this over the line. If you are enjoying working on Meridian, starring the repository helps more contributors find the project and is much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Keeper heartbeat and snapshot stores ignore the store-prefixed Upstash variables

2 participants