Repository navigation
Show Phantom's logo on the EVM list - #4
Merged
Merged
Conversation
Phantom announces its icon with a leading newline, so the anchored data:image/https check rejected it and the modal fell back to a letter. Trim the value before checking; the allowlist itself is unchanged.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Phantom announces its EIP-6963 icon with a leading newline (
"\ndata:image/png;base64,..."). The anchoreddata:image//https://check rejected it, so the modal fell back to a letter. The value is now trimmed before the check; the allowlist is unchanged.Checks
Typecheck, lint and the wallet tests pass (new cases for Phantom's format and a padded
javascript:URL).🤖 Generated with Claude Code