Repository navigation
Feat/merged pr features clean - #31
dsactivi-2 wants to merge 4 commits into
Conversation
Components (with test-IDs): - NEW: ThemeProvider.tsx - dark/light/system theme switching - NEW: ThemeToggle.tsx - theme toggle dropdown button - MERGED: AgentCard.tsx - added spokenLanguage, agentType, contentAutonomy - MERGED: CreateAgentDialog.tsx - added influencer type, spoken language selector Documentation: - NEW: docs/AGENT_CONTROL.md - Agent Control API documentation Fix: - Fixed unused parameter warning in brain-proxy.ts Features merged from PRs: - PR #2: ThemeProvider, ThemeToggle - PR #4: Influencer agent type, Serbian language support, content autonomy - PR #7: AGENT_CONTROL.md API documentation All components include data-testid attributes following naming convention: cloudagents.{component}.{element}.{action} 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Auto-fixed by GitHub Actions
Components updated:
- ActivityLog.tsx: cloudagents.activitylog.* test-IDs
- DemoDashboard.tsx: cloudagents.demodashboard.* test-IDs
- DemoPage.tsx: cloudagents.demopage.* test-IDs
- StatsCard.tsx: cloudagents.statscard.* test-IDs
- StatusDashboard.tsx: cloudagents.statusdashboard.* test-IDs
- TeamAgentCard.tsx: cloudagents.teamagent.* test-IDs
- TeamAgentList.tsx: cloudagents.teamagentlist.* test-IDs
All test-IDs follow the naming convention: cloudagents.{component}.{element}
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Auto-fixed by GitHub Actions
|
@sentry review |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| onCreate({ | ||
| name, | ||
| description, | ||
| language, | ||
| code, | ||
| spokenLanguage, | ||
| agentType, | ||
| contentAutonomy: agentType === "influencer" ? contentAutonomy : false, | ||
| }); |
There was a problem hiding this comment.
Bug: New agent properties (agentType, contentAutonomy) are passed from CreateAgentDialog but are ignored by handleCreateAgent and not stored, breaking influencer-specific UI features in AgentCard.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The CreateAgentDialog component correctly passes new agent properties (spokenLanguage, agentType, contentAutonomy) to its onCreate callback. However, the handleCreateAgent function in App.tsx is not typed to receive these new properties, and they are not included in the Agent interface. Consequently, this data is lost when a new agent is created. This prevents the AgentCard component from correctly rendering UI elements specific to the "influencer" agent type, as its conditional logic relies on the agentType and contentAutonomy properties, which will be undefined.
💡 Suggested Fix
Update the handleCreateAgent function signature in App.tsx to accept the new properties (spokenLanguage, agentType, contentAutonomy). Add these properties to the Agent interface to ensure they are stored correctly with the agent object.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: src/components/CreateAgentDialog.tsx#L72-L80
Potential issue: The `CreateAgentDialog` component correctly passes new agent properties
(`spokenLanguage`, `agentType`, `contentAutonomy`) to its `onCreate` callback. However,
the `handleCreateAgent` function in `App.tsx` is not typed to receive these new
properties, and they are not included in the `Agent` interface. Consequently, this data
is lost when a new agent is created. This prevents the `AgentCard` component from
correctly rendering UI elements specific to the "influencer" agent type, as its
conditional logic relies on the `agentType` and `contentAutonomy` properties, which will
be `undefined`.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 508902
Fix Git hooks for Husky v9 compatibility
Co-authored-by: den-is9186 <257160258+den-is9186@users.noreply.github.com>
2 participants
No description provided.