You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Extend LF line-ending normalization to remaining runtime generators #1345
#1331 added LfNormalizingFileSystemAccess and wired it into CheckGenerator and CheckCfgGenerator so generated output is LF regardless of host OS. The same risk pattern exists in three other runtime IGenerator/IGenerator2 classes that emit Java sources to committed src-gen/ directories — they were not addressed in #1331.
Plus an FSA-bypass writer that needs separate handling:
KeywordAnalysisHelper uses raw PrintWriter (.println() → platform line separator) at lines 183, 444, 448 — writes report and documentation files to srcGenPath. The decorator-wrapper approach doesn't apply here; fix is either explicit \n or a BufferedWriter with explicit LF.
Why this matters
.gitattributes (* text=auto eol=lf) normalizes on commit, so the committed state and the line-endings CI check stay green. The value is preventing working-tree noise for Windows developers: after regeneration, every file shows as modified in git status/git diff due to EOL drift relative to the index.
Suggested approach
Hoist LfNormalizingFileSystemAccess from com.avaloq.tools.ddk.check.core to a shared bundle (e.g. com.avaloq.tools.ddk.xtext) so the three generators above can depend on it without pulling in check.core.
Activity
chore: remove LfNormalizingFileSystemAccess (now superseded by config)
chore: emit LF from MWE2 code generation
fix(generator): emit LF explicitly in KeywordAnalysisHelper reports
fix: deterministic LF line endings for generated files via ILineSepar…
fix(generator): emit LF explicitly in KeywordAnalysisHelper reports
fix: deterministic LF line endings for generated files via ILineSepar…
fix(generator): emit LF explicitly in KeywordAnalysisHelper reports
fix: deterministic LF line endings for generated files via ILineSepar…
fix(generator): emit LF explicitly in KeywordAnalysisHelper reports
fix: deterministic LF line endings for generated files via ILineSepar…
joaodinissf commentedon Oct 25, 2026
Closing — verified fixed.
Posted by Claude Code on behalf of @joaodinissf.