Skip to content

fix(caching): mark MultiCacheStatistics' counter warning as a false positive #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaodinissf merged 1 commit into from
Oct 16, 2026
+10 −8
Merged

fix(caching): mark MultiCacheStatistics' counter warning as a false positive #1573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion com.avaloq.tools.ddk.feature/feature.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<feature
id="com.avaloq.tools.ddk.feature"
label="com.avaloq.tools.ddk.feature"
version="19.3.0.qualifier"
version="19.3.1.qualifier"
provider-name="Avaloq Group AG">

<description>
Expand Down
2 changes: 1 addition & 1 deletion com.avaloq.tools.ddk.feature/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<version>18.0.1-SNAPSHOT</version>
<relativePath>../ddk-parent</relativePath>
</parent>
<version>19.3.0-SNAPSHOT</version>
<version>19.3.1-SNAPSHOT</version>

<artifactId>com.avaloq.tools.ddk.feature</artifactId>
<packaging>eclipse-feature</packaging>
Expand Down
2 changes: 1 addition & 1 deletion com.avaloq.tools.ddk.runtime.feature/feature.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<feature
id="com.avaloq.tools.ddk.runtime.feature"
label="com.avaloq.tools.ddk.runtime.feature"
version="19.3.0.qualifier"
version="19.3.1.qualifier"
provider-name="Avaloq Group AG">

<description>
Expand Down
2 changes: 1 addition & 1 deletion com.avaloq.tools.ddk.runtime.feature/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<version>18.0.1-SNAPSHOT</version>
<relativePath>../ddk-parent</relativePath>
</parent>
<version>19.3.0-SNAPSHOT</version>
<version>19.3.1-SNAPSHOT</version>

<artifactId>com.avaloq.tools.ddk.runtime.feature</artifactId>
<packaging>eclipse-feature</packaging>
Expand Down
2 changes: 1 addition & 1 deletion com.avaloq.tools.ddk/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: com.avaloq.tools.ddk
Bundle-SymbolicName: com.avaloq.tools.ddk;singleton:=true
Bundle-Version: 17.3.1.qualifier
Bundle-Version: 17.3.2.qualifier
Bundle-Vendor: Avaloq Group AG
Bundle-RequiredExecutionEnvironment: JavaSE-21
Bundle-ActivationPolicy: lazy
Expand Down
2 changes: 1 addition & 1 deletion com.avaloq.tools.ddk/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
<groupId>com.avaloq.tools.ddk</groupId>
<artifactId>com.avaloq.tools.ddk</artifactId>
<packaging>eclipse-plugin</packaging>
<version>17.3.1-SNAPSHOT</version>
<version>17.3.2-SNAPSHOT</version>

</project>
2 changes: 2 additions & 0 deletions com.avaloq.tools.ddk/src/com/avaloq/tools/ddk/caching/CacheManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import com.avaloq.tools.ddk.annotations.SuppressFBWarnings;
import com.google.common.cache.CacheLoader;
import com.google.common.collect.ArrayListMultimap;
import com.google.common.collect.Maps;
Expand Down Expand Up @@ -245,6 +246,7 @@ private final class MultiCacheStatistics extends CacheStatistics {
private int counter;

@Override
@SuppressFBWarnings("AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE") // instances are local to the thread that fills and reads them
void aggregate(final CacheStatistics statistics) {
counter++;
super.aggregate(statistics);
Expand Down
4 changes: 2 additions & 2 deletions ddk-repository/category.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
<site>
<feature url="features/com.avaloq.tools.ddk.feature_19.3.0.qualifier.jar" id="com.avaloq.tools.ddk.feature" version="19.3.0.qualifier">
<feature url="features/com.avaloq.tools.ddk.feature_19.3.1.qualifier.jar" id="com.avaloq.tools.ddk.feature" version="19.3.1.qualifier">
<category name="com.avaloq.tools.ddk.sdk"/>
</feature>
<feature url="features/com.avaloq.tools.ddk.runtime.feature_19.3.0.qualifier.jar" id="com.avaloq.tools.ddk.runtime.feature" version="19.3.0.qualifier">
<feature url="features/com.avaloq.tools.ddk.runtime.feature_19.3.1.qualifier.jar" id="com.avaloq.tools.ddk.runtime.feature" version="19.3.1.qualifier">
<category name="com.avaloq.tools.ddk.runtime"/>
</feature>
<category-def name="com.avaloq.tools.ddk.sdk" label="DSL Developer Kit"/>
Expand Down