Support Zed in the UI: add to IDE dropdown and fix Open-in-IDE link#3963
Open
peterschmidt85 wants to merge 2 commits into
Open
Support Zed in the UI: add to IDE dropdown and fix Open-in-IDE link#3963peterschmidt85 wants to merge 2 commits into
peterschmidt85 wants to merge 2 commits into
Conversation
Backend support for the `zed` IDE already exists (#3947), but the run launch UI never offered it. Add Zed to the IDE options dropdown and the related form/run types so it can be selected from the UI. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The run details "Open in IDE" button hand-rolled the URL as
`{ide}://vscode-remote/ssh-remote+...`, which is correct only for VS Code
forks. Zed — the first non-fork IDE, now selectable in the dropdown — needs
`zed://ssh/...`, so the button produced a broken link.
Use the per-IDE URL the server already computes and exposes via
`JobConnectionInfo.attached_ide_url` (built by `ide.get_url`), making the UI a
single source of truth instead of duplicating the URL logic. This also fixes
latent issues the hand-rolled URL had for non-primary jobs/replicas (host
should be the job name) and IPv6/port formatting.
Extend the runs API connection-info test to cover all IDEs
(vscode/cursor/windsurf/zed) with and without sshproxy.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
peterschmidt85
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly supports Zed in the web UI:
{ide}://vscode-remote/ssh-remote+…, which only works for VS Code forks — Zed needszed://ssh/…, so the button was broken. The UI now uses the per-IDE URL the server already provides (JobConnectionInfo.attached_ide_url) instead of duplicating the logic.🤖 Generated with Claude Code