Skip to content

Fix fee validation, dispute persistence, and analytics capacity - #310

Merged
dultimateade merged 2 commits into
dultimateade:mainfrom
reactjay:fix/fee-dispute-analytics-issues
Oct 17, 2026
Merged

dultimateade merged 2 commits into
dultimateade:mainfrom
reactjay:fix/fee-dispute-analytics-issues

Conversation

@reactjay

Copy link
Copy Markdown
Contributor

Summary

  • Reject enabled fee configurations with a zero minimum fee, and document deposit, withdrawal, and admin collection fee behavior.
  • Persist disputes with sequential IDs and update stored records through their lifecycle.
  • Enforce analytics capacity using the stored summary count and avoid writing before summary validation completes.

Fixes #235
Fixes #236
Fixes #237
Fixes #239

Verification

  • Added regression coverage for enabled zero-minimum fees, dispute persistence, and capacity count stability.
  • git diff --check passed. Cargo tests could not be run because cargo is unavailable in the environment.

@drips-wave

drips-wave Bot commented Oct 17, 2026

Copy link
Copy Markdown

@reactjay Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@dultimateade
dultimateade merged commit ea3c46e into dultimateade:main Oct 17, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment