Repository navigation
fix: support ino in --output-attrs to preserve hardlinks - #686
Merged
Merged
Conversation
Exporting with explicit --output-attrs previously dropped ino and hlnkc for hardlinked files because emission checked attributes == nil, and parseJSONAttributes rejected "ino". This caused reimported exports to treat hardlinked files as independent entries, inflating apparent size.
Accept "ino" in parseJSONAttributes, gate emission on attributes.Includes("ino") for hardlinks in memory and SQLite encoders, and update flag documentation in main and README.
dundee
approved these changes
Oct 5, 2026
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #667
Problem
When users export directory scans with explicit --output-attrs, hardlink identity fields (ino and hlnkc) are dropped because both the in-memory (pkg/analyze/encode.go) and SQLite (pkg/analyze/sqlite.go) encoders check attributes == nil && Flag == 'H'. Additionally, parseJSONAttributes in cmd/gdu/app/output_attrs.go rejected ino with an unknown attribute error, preventing users from selecting hardlink attributes. Re-importing such filtered exports causes formerly hardlinked files to be treated as distinct files, inflating calculated directory sizes.
Solution