Repository navigation
fix(stdout): print the displayed item count with --show-item-count - #691
Open
LuisFigueroaG wants to merge 1 commit into
Open
LuisFigueroaG wants to merge 1 commit into
LuisFigueroaG wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #691 +/- ##
=======================================
Coverage 90.73% 90.73%
=======================================
Files 76 76
Lines 6843 6844 +1
=======================================
+ Hits 6209 6210 +1
Misses 633 633
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
The lint failure isn't from this change: golangci-lint v2.13.2 can't load go1.27.2 export data ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
-n -Cthe item count depended on how the tree was scanned. The default scan printed3for a directory with three items and0for an empty one.--sequential, multiple paths, and-finput printed4and1, because stdout printed the rawGetItemCount(), which includes the directory itself.stdout now prints
fs.DisplayedItemCountlike the TUI and web UI (ADR 0001). The top-dir analyzer used by default in non-interactive mode now uses the same raw counts asDir(a directory includes itself, files count 1), so the displayed value is the same for every analyzer.Added a test that runs the same tree through the top-dir, parallel and sequential analyzers.
make lintandgo test ./...pass.