Repository navigation
fix(analyze): zero disk usage instead of apparent size for online-only files - #692
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #692 +/- ##
==========================================
+ Coverage 90.73% 90.74% +0.01%
==========================================
Files 76 76
Lines 6843 6843
==========================================
+ Hits 6209 6210 +1
Misses 633 633
+ Partials 1 0 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #688.
Problem
In #609, support was added to detect cloud "online-only" files (such as OneDrive placeholders) via Windows file attributes FILE_ATTRIBUTE_RECALL_ON_OPEN (0x100000) and FILE_ATTRIBUTE_RECALL_ON_DATA_ACCESS (0x400000). However, setPlatformSpecificAttrs set file.Size = 0 (apparent size) instead of zeroing file.Usage (disk usage), while keeping file.Usage = f.Size(). Consequently:
Solution