Repository navigation
fix(app): stream the right iPhone and show wipe/delete progress toasts - #70
Merged
Merged
Conversation
Streaming iOS devices only works over USB for now; Wi-Fi streaming is not supported yet. findDevice fell back to the only USB capture device when no name matched, so with one iPhone on USB and another on Wi-Fi only, both streams showed the USB one. Match by name only (the capture device's localizedName is the name devicectl reports) and tell the user to connect the Wi-Fi-only device by cable.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 6
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (6 files)
Reviewed by free · Input: 64.3K · Output: 16.3K · Cached: 441.6K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two desktop app fixes for 0.3.1.
Wi-Fi-only iPhone streamed another iPhone's screen. With one iPhone on USB and another on Wi-Fi only, both stream tiles showed the USB one. Streaming iOS devices only works over USB for now; Wi-Fi streaming is not supported yet.
findDeviceinDeviceStream.swiftfell back to the only USB capture device when no name matched, so the Wi-Fi-only device got the other phone's capture. It now matches by name only (the capture device'slocalizedNameis the same namedevicectlreports, checked on real devices) and otherwise fails with: "… is not connected by USB cable (or is locked). Streaming over Wi-Fi is not supported yet: connect it with a cable and unlock it."Wipe / delete toasts. "Wiping…" / "Deleting…" was a plain info toast with no spinner that stayed up, and the success message went through the error path, so "Deleted X" showed in red. Device notices now carry a kind (
info,busy,success,error) and a device id. Wipe and delete show a loading toast with a spinner, which closes when the green success or red error toast for that device appears.DevicesCubit.notifykeeps its signature for the MCP tools.Both are in the 0.3.1 changelog under Fixed.
Tests: new
DevicesCubitcases for loading → success and loading → error on wipe and delete.flutter analyzeis clean and all 100 app tests pass. The Swift change was checked by building and running the app; streaming two iPhones (one USB, one Wi-Fi) after the fix was not re-tested.Type of Change