Skip to content

fix(app): stream the right iPhone and show wipe/delete progress toasts - #70

Merged
dungngminh merged 2 commits into
mainfrom
fix/ios-stream-wrong-device
Oct 14, 2026
Merged

dungngminh merged 2 commits into
mainfrom
fix/ios-stream-wrong-device

Conversation

@dungngminh

Copy link
Copy Markdown
Owner

Description

Two desktop app fixes for 0.3.1.

Wi-Fi-only iPhone streamed another iPhone's screen. With one iPhone on USB and another on Wi-Fi only, both stream tiles showed the USB one. Streaming iOS devices only works over USB for now; Wi-Fi streaming is not supported yet. findDevice in DeviceStream.swift fell back to the only USB capture device when no name matched, so the Wi-Fi-only device got the other phone's capture. It now matches by name only (the capture device's localizedName is the same name devicectl reports, checked on real devices) and otherwise fails with: "… is not connected by USB cable (or is locked). Streaming over Wi-Fi is not supported yet: connect it with a cable and unlock it."

Wipe / delete toasts. "Wiping…" / "Deleting…" was a plain info toast with no spinner that stayed up, and the success message went through the error path, so "Deleted X" showed in red. Device notices now carry a kind (info, busy, success, error) and a device id. Wipe and delete show a loading toast with a spinner, which closes when the green success or red error toast for that device appears. DevicesCubit.notify keeps its signature for the MCP tools.

Both are in the 0.3.1 changelog under Fixed.

Tests: new DevicesCubit cases for loading → success and loading → error on wipe and delete. flutter analyze is clean and all 100 app tests pass. The Swift change was checked by building and running the app; streaming two iPhones (one USB, one Wi-Fi) after the fix was not re-tested.

Type of Change

  • 🔥 New feature (non-breaking change which adds functionality)
  • ✨ Enhancement (non-breaking change which improves existing functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • 🧹 Code refactor
  • 📝 Documentation
  • 🗑️ Chore
  • 📦 Build configuration change
  • ✅ Test

Streaming iOS devices only works over USB for now; Wi-Fi streaming is not
supported yet. findDevice fell back to the only USB capture device when no
name matched, so with one iPhone on USB and another on Wi-Fi only, both
streams showed the USB one. Match by name only (the capture device's
localizedName is the name devicectl reports) and tell the user to connect
the Wi-Fi-only device by cable.
@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 84509129-7914-4238-a215-6c24092f8c82
📥 Commits

Reviewing files that changed from the base of the PR and between f7d646f and 3244a32.

📒 Files selected for processing: 6
  • app/CHANGELOG.md
  • app/lib/src/devices/devices_cubit.dart
  • app/lib/src/ui/recording_toast.dart
  • app/macos/Runner/DeviceStream.swift
  • app/test/devices_cubit_test.dart
  • app/test/run_scenario_test.dart
 ____________________________________________________________________
< There is a 100% chance that this message is relevant to your code. >
 --------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dungngminh
dungngminh merged commit 4899e29 into main Oct 14, 2026
6 of 7 checks passed
@dungngminh
dungngminh deleted the fix/ios-stream-wrong-device branch October 14, 2026 09:20
@kilo-code-bot

kilo-code-bot Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (6 files)
  • app/CHANGELOG.md
  • app/lib/src/devices/devices_cubit.dart
  • app/lib/src/ui/recording_toast.dart
  • app/macos/Runner/DeviceStream.swift
  • app/test/devices_cubit_test.dart
  • app/test/run_scenario_test.dart

Reviewed by free · Input: 64.3K · Output: 16.3K · Cached: 441.6K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant