Repository navigation
feat: wipe or delete emulators and simulators from TUI and CLI - #74
Merged
Merged
Conversation
TUI: `d` wipes a shut-down emulator/simulator's data, `D` deletes it, both behind a confirmation dialog. CLI: `simutil wipe <id>` and `simutil delete <id>` ask y/N first; `-y/--yes` skips the prompt. Physical and running devices are refused. Closes #50
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 14
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (14 files)
Reviewed by free · Input: 28.8K · Output: 1.3K · Cached: 176.7K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #50.
dwipes a shut-down emulator/simulator's data (apps, settings, snapshots),Ddeletes it. Both show a confirmation dialog first. Running devices get a "shut it down first (t)" hint; physical devices are ignored. Status bar lists the new keys for shut-down emulators/simulators.simutil wipe <device-id>andsimutil delete <device-id>ask y/N before running;-y/--yesskips the prompt. Physical and running devices are refused with exit 1. Both accept-a/-ilikeshutdown, and are in theschemacatalog and README.version.dart/changelog_entries.dart).Uses the existing
DeviceService.wipeData/deleteSimulatorfromsimutil_core(already used by the desktop app).Tests: device list
d/Dkey routing; CLI wipe/delete prompt, decline,--yes, running-device refusal.dart analyze --fatal-infosclean,dart testpasses. Not yet tried against a real AVD / simulator.POW
demo-delete-1792174167234.mp4
Type of Change
Summary by CodeRabbit
-yor--yesin the CLI to skip them.