Repository navigation
Conversation
rmcdaniel
left a comment
There was a problem hiding this comment.
Security source/conformance review: PASS, scoped to exact 9db331e1efe69d5992d1ea5fc604a673b7827210 over base 57c23b63c77284371bfc83f2ba562bdf4230ddaf.
I independently checked the changed inventory against the pinned primary sources. PHP f9483bb2 exposes listWorkflows / workflowHistory and the lazy iterateWorkflows / iterateWorkflowHistory generators with the shown pageSize call shape. Python 9e77bc8e exposes the corresponding one-page methods and iter_workflows / iter_history async iterators with fixed namespace and exact-run handling. The retained Python observation link resolves to the Security-reviewed SDK 2.17.2 / Server 3.9.2 multi-page result, and the separate Docs 548 readback supports only the published guide claim.
The failover correction also matches Server c4070777: cleanup_project() returns a separate failure diagnostic and main() writes the result in finally; merged Server #700 is the owning repair. The new prose correctly refuses to treat that source repair, an older runner copy, a cleanup failure, or missing output as failover qualification.
No runtime or cross-binding acceptance is inferred. PHP installed pagination remains unfinished, and the shared-contract check stopped at the existing retired setup action; normal current-head qualification after the independently reviewed #400/#404 activation remains required.
|



The public guidance omits shipped Python/PHP iterator APIs, keeps a resolved failover cleanup defect in the current instructions, and describes PHP metrics as unfinished after its installed qualification completed. Update those three descriptions against the actual published sources and named receipts. PHP's installed pagination qualification remains unfinished.
Validation: immutable published Python 2.17.2 and PHP 3.18.2 API signatures were checked, the Python example parses inside an async function, and the PHP named parameter matches its published signature. Two isolated controls on the current failover cleanup function confirm success and retained timeout failure without creating a process. The existing PHP published-Worker run is terminal success, and the live exporter guide returns HTTP 200 with the seven contract names and recorder/exporter API. The metric contract JSON is unchanged. Markdown fences and
git diff --checkpass. No runtime invocation, new failover result or later-contract adoption is claimed.Refs #122, #247 and completed #233. Security's review at 9db331e covers the pagination/failover changes; the successor adds only the PHP metrics README correction. Shared-contract CI stops at the existing setup-php 411a HTTP 404 before tests; #400/#404 owns the repair. Normal exact-head qualification remains required.