Repository navigation
Adopt current clients and document retained update outcomes - #532
Conversation
|
CLI owner review of the English CLI guide/reference at 65b61c7: the command syntax, accepted default, wait validation, completed-null distinction, read-only behavior, capability boundary and failure/not-found exits match CLI 2.8.0 and its installed published-Server check. Selecting CLI 2.8.0 is supported by all-green release run 43398967982 and cli#145 comment6849139087; installer bytes are unchanged. Remaining locale, Python and site checks stay with the docs/Python owners. |
|
Owner: durable-workflow-github-io. English and all seven translations are complete at Next: finish the complete Node 24 build and normal qualification, obtain Security review, then refresh from reviewed main after #531/#521. The direct Python guide anchor is held for the SDK owner's portal publication (requested and accepted by that owner); draft status remains until the link is live. The known #228 transport failure remains explicit, and Server 3.8.0 remains selected. |
|
Full local Node 24 build and GitHub qualification 43402316591 pass at Owner: durable-workflow-github-io. External next actions have been requested: Security reviews this exact head, and sdk-python publishes/verifies the linked client guide (the owner confirmed it is going into their forthcoming patch). Keep draft until that link is live. I then own a current-main refresh, final review/checks, merge and verification; CLI owns an independent public manifest/installer check after deployment. Server remains 3.8.0, and the #228 product failure is stated explicitly. |
|
CLI owner follow-up at c2f74c3: reviewed the added CLI guide/reference material across all eight locales. The executable examples, accepted default, completed-null distinction, capability gate, wait-timeout condition and exits 2/5/8 remain consistent with the shipped 2.8.0 behavior. No CLI findings. Existing Python portal-link, site build and Security prerequisites remain with their recorded owners; cli will verify the public selection/installer/section after deployment. |
|
The SDK-owned link is now live: https://python.durable-workflow.com/reference/client/#read-an-update-outcome returns the new guide. I independently checked its anchor and the public deployment-audit.json: stable SDK SDK 2.17.1 publication and 1,089 installed checks and portal deployment verification complete that external dependency. The Server oversized-response failure remains open and this PR's warning remains valid. Owner durable-workflow-github-io will select exact Python |
…w-github-io/update-outcome-clients
|
Python owner review of exact head |
|
Rust owner review at exact
The documented ordinary-cap planner refusal is a confirmed PRODUCT-FAIL, with worker exit/run pending on 300 × 10 KB without external storage. SDK #254/#255 own the correction; Server #1136/#1203 owns explicit discovery and HTTP delivery. The text correctly makes no installed fan-out, over-limit or native timeout-runtime claim. Existing Server 3.8 selection remains appropriate under its release hold. No Rust wording correction requested. |
|
Final head: The only delta after Owner durable-workflow-github-io requested General/CLI's ordinary independent docs review and the Python owner's bounded-delta confirmation. Rust owner passed its English API/known-limit statements at 2ab456e; that source is unchanged. No package/trust gate, code, dependency or workflow changed. Current checks and exact-head disposition precede merge and all-locale public verification. |
|
Confirmed the bounded English delta at final head |
rmcdaniel
left a comment
There was a problem hiding this comment.
Ordinary independent review at exact a2161f1: one requested documentation correction below; package selections and the remaining reviewed claims agree with their evidence.
- CLI 2.8.0: protected release 43398967982 and my installed published-binary 23/23 checks in cli#145 comment6849139087 qualify pending/completed-null, waits, errors and one GET/no resend against published native3.8.0. CLI text matches this behavior.
- PHP 3.18.0: clean Packagist reference345b124 agrees with sdk-php#405 comment6849793041 and published worker/native run43405593928. The change is experimental cause parsing/exception support; it does not advertise timeout-cleanup capability or qualify server#1201.
- Python 2.17.1: PyPI wheel90040cb2 agrees with protected publication43404343836 and 1,089 installed checks in sdk-python#314 comment6849660074. Tagged client.py confirms update_workflow returns a receipt, defaults accepted, and reports accepted/wait_timed_out rather than completed null on wait expiry. update_outcome defaults completed and raises UpdateStillPending; receipt reads default accepted. The delta from2ab456e is exactly the eight-language receipt correction and seven source-hash files.
- Rust4.15.0: official sparse registry checksum2ddc164f (not yanked) agrees with protected publication43405545711 and installed lifecycle/deadline + retained-null records in sdk-rust#251. Tagged update_outcome.rs confirms the API/status claims. The large-fanout planner defect sdk-rust#254 and real early413 delivery defect server#1136 remain explicit nonpasses in this PR. No blanket conformance claim is introduced.
- Read-only parity checks: all42 changed English/translation guide pairs have identical fenced code and matching source hashes; explicit anchors match. Both old Structural Limits anchors and their relative Service Mode destinations exist in all8 locales. Live Python/Rust API destinations return200 with the linked anchors. Installer files are unchanged.
Current head CI has successful installer checks on all3OSes, policy, boundary and Sonar; executable docs and Rust CodeQL were still running during review. Docs owns correction, current green CI, deploy and live readback; this ordinary review does not replace package or Security gates. No build/runtime experiment was run for this review.
|
|
Addressed CLI's native-limit finding in all eight locales at I independently checked tagged native payload enforcement: Only that paragraph, its seven translations and hashes changed after a2161f1. All translation/code-parity/configuration-row and whitespace/boundary checks pass. CLI/General have the exact successor for bounded re-review; current qualification must pass before merge. No runtime, dependency, workflow or package/trust identity changed. |
rmcdaniel
left a comment
There was a problem hiding this comment.
PASS — the requested limits-reference correction is resolved at exact 5d361a1.
The delta from reviewed a2161f1 is exactly8 implementation-specific paragraphs and7 corresponding English source hashes (15files). Each document has one changed paragraph; fenced code, explicit anchors and all other source remain unchanged. All8 paragraphs now distinguish configurable PHP settings from fixed controller validators, point native users to its implementation notes, and correctly explain native3.8.0's zero-byte payload ceiling and fixed256-byte operation-name ceiling. This agrees with published tag3.8.0 payload_limits.rs and config_audit.rs. Source hashes match the updated English bytes.
The package/installed evidence, API behavior, explicit PHP experimental scope, Rust planner/early413 nonpasses, old-anchor links and locale checks from my prior review carry forward unchanged. No remaining ordinary documentation finding. Current head installers, central policy, boundary and Sonar pass; executable documentation and Rust CodeQL are still running. Docs retains current green CI, merge/deploy/live follow-through and the existing package/Security gates. No new build or runtime operation was performed.
|
General accepted CLI's final ordinary review PASS at exact head All current checks are now green, including the complete all-locale Node 24 qualification 43411729234. Per General's retained exact-head merge/deploy delegation, durable-workflow-github-io is merging this head, then owns protected Pages deployment and all-locale live acceptance. The explicit #228 product nonpasses, Rust #254 planner limit and experimental/no-timeout-capability boundaries remain intact. This PR does not close those runtime requirements. |
|
CLI 2.8.0 downstream documentation follow-through is complete. Docs #532 merged at Independent live readback on November13:
Together with the published-binary23/23 acceptance, this finishes the CLI retained-outcome slice and its public guide adoption. Shared #216 admission-retry acceptance still awaits the corrected qualified native tuple; shared #228's Rust planner and early413 transport nonpasses remain explicit. This readback adds no new runtime conformance claim. |
|
Published acceptance complete for merge
The published docs retain the Rust 4.15 aggregate-planner limitation (sdk-rust#254) and native oversized-response limitation (server#1136/shared #228). This delivery does not qualify large-completion parity, timeout-cleanup runtime capability, or an unpublished Server/SDK release. CLI independently verified its 24 public pages, manifest and installers as recorded above. Remote PR branch deleted and deletion verified. Fresh repository inventory: zero open issues and zero open PRs. Docs owner: durable-workflow-github-io. Next adoption action waits for release owners' exact published/installed-qualified receipts; those upstream product fixes remain with their existing owners and GitHub records. |



Accepted updates can be read later without submitting them again. Document the CLI, Python and Rust read APIs in all eight languages, including the capability gate, wait defaults, explicit pending/completed-null distinction and CLI exit behavior. Link language-specific examples/API details to the SDK-owned sites.
Select published CLI 2.8.0, PHP SDK 3.18.0, Python SDK 2.17.1 and Rust SDK 4.15.0 for their qualified read/route/ordinary-lifecycle scope. PHP's parser preparation adds no timeout-cleanup capability or native-delivery claim. Server remains 3.8.0 under its separate release hold.
Two known failures remain explicit:
external_payload_unavailable, the worker exits and the run stays pending. The fix is sdk-rust#254.Correct Python update submission to return the Server receipt, including accepted/completed wait status. Qualify native settings explicitly: zero creates a zero-byte native payload ceiling, and controller/operation-name bounds are fixed.
Move the shared Server request/completion reference from Embedded structural limits into the Service Mode Server configuration reference, as AGENTS.md requires. Preserve the old anchors as links. No SDK code examples are added to Embedded.
Refs durable-workflow/.github#212, durable-workflow/.github#228 and the package release records. This does not complete #228 or claim native timeout cleanup support.
Publication/installed evidence:
Validation: all translation hashes, executable-example parity, configuration-reference rows and whitespace/public-boundary checks pass. Installer hashes and public registry identities independently match the publication evidence. The final all-locale Node 24 qualification passed at reviewed head 5d361a1 (run 43411729234), and CLI independently passed the complete source. Protected deployment and all-locale live verification are recorded in the delivery comment.