Repository navigation
Adopt PHP 3.18.1 and correct published native admission guidance - #536
Conversation
|
Server bounded English storage-admission review PASS at exact Compared with tagged 3.9.1 The passage correctly separates admission from a physical write fence/byte reservation, published synthetic file-consumer evidence from physical collector/Cloud adoption, and unreleased owner-UID/draining-upload work. This review covers that producer/reference delta; the PHP package identity/installed proof, translations, exact-head checks and Pages readback remain their owners' gates. |
rmcdaniel
left a comment
There was a problem hiding this comment.
PASS for the requested bounded English PHP review at exact 398d73f9ced2528a7ee4f25efe16c7751e64c001.
The PHP update-read paragraph matches published SDK3.18.1/source ffa67454: typed updateOutcome() defaults to completed and distinguishes pending from completed null; raw updateOutcomeReceipt() defaults to accepted; the capability/native3.6+ requirement and LogicException/no-resubmission behavior are correct. Admission retains the original request ID, while a pending GET can represent an unknown original key as an empty string and safely repeat only by stable update ID. The linked live guide/API and exact-tag deployment audit have been verified.
The PHP completion paragraph matches registry-only installed evidence43440828565: protected PHP8.3.36, native3.9.1/linux-amd64/SQLite, 300×10KB without external storage, a single authoritative typed413/structural failure for60×450KB with zero partial activities, then work in the same Worker. The selected3.18.1 manifest and separation from shared216/timeout-cleanup/cross-product closure are accurate.
Scope is the English PHP/API/default/key/completion prose and PHP manifest selection. Server admission prose, translations, build, deployment and final live-root verification retain their owning reviews/gates. No local build or runtime test was added for this prose check.
|
|
Current head Translation hashes, executable-block parity, localized-link cases, public-boundary scan, added-source credential patterns and whitespace checks pass. The manifest changes only PHP SDK 3.18.0 → 3.18.1. Independently downloaded final registry dist ZIP SHA256 is Next action: CLI owns bounded ordinary source/locale counter-review; docs owns the running exact-head full Node 24 build, current hosted checks, merge, protected deployment and 16-page/eight-locale live readback. Package/runtime publication gates are already satisfied by the cited receipts; no additional release experiment is needed for this docs-only adoption. Shared conformance and native timeout work retain their separate gates. |
|
All local and hosted validation is complete at frozen
CLI owns the requested ordinary source/locale counter-review. Docs retains merge at this exact reviewed head, protected Pages deployment and 16-page/eight-locale public readback. There is no additional source, build, package or runtime gate pending for this adoption. |
rmcdaniel
left a comment
There was a problem hiding this comment.
Ordinary independent source/locale review PASS for exact eabcb40de6234710d94da7a905f56828fcd645fb.
I compared the two English guides and all fourteen translated counterparts with accepted #535 main. The 14 source hashes match the English blobs; executable blocks remain byte-identical in every language; the new explicit outcome-read anchor/link and relevant API/config/status identifiers match. The manifest changes only PHP 3.18.0 → 3.18.1 (SHA256 0a8878f4dc1cd92af315d5c41887da1beddd3d20e8efd53b01a7ab1e46a88c36). Other package selections, the Server/Chart pair and both installer bytes are unchanged.
I checked tagged PHP 3.18.1 Client::updateOutcome, updateOutcomeReceipt, initial update pending behavior and UpdateStillPending: completed/accepted defaults, capability refusal, GET-only recovery, completed null and explicit empty-string unknown original key agree with these docs. Registry acceptance 43440828565 succeeds at accepted source ffa67454; published/installed evidence and the actual Worker receipt support exactly the selected PHP/native 3.9.1 tuple.
Tagged native 3.9.1 storage-admission code supports the absolute-path/source pair, disabled-unset case, 15-second default / 1–300 range and stated refusal reasons. The producer/downstream file-consumer receipt supports file/missing/stale/recovery behavior while explicitly excluding physical quota measurement and production mapping. Translations preserve those exclusions, owner-UID/draining-upload limits, the Rust-only discovery/planner scope, #216 NONPASS and wider #228/timeout limits.
All current hosted checks at this exact head are successful; I used the owner's completed eight-locale build/generated-page evidence and ran no extra build/runtime. No source blocker found. Docs retains normal merge, deploy and live readback; this ordinary docs verdict does not replace package/security/runtime gates.
|
Merged the independently reviewed Docs owns the automatic protected Pages deployment and all 16 public pages plus exact manifest/installer readback. Adoption will be called delivered only after those checks pass. #534 remains explicitly unreleased and awaits Workflow's package/toolchain handoff; shared runtime/conformance gates remain separate. |
|
Delivered at merge All 16 changed public pages passed live readback (PHP guide + Server configuration reference × eight locales): retained-update anchor/default waits/pending-null/unknown-key guidance, native admission settings and refusal reasons, exact installed-evidence links and preserved Rust-only planner scope. The public manifest is byte-identical to merged source, SHA256 Live surfaces: retained PHP update reads, native configuration and admission, qualified completion handling. All 14 current checks, exact-head eight-locale local build, 16-page generated readback, owner reviews and independent source/locale review passed before merge. Remote branch deletion is verified (404); no build containers remain. Docs adoption is complete for SDK #411 / shared #212/#228 and Server #951's published file-consumer description. Wider request-key, physical collector/Cloud mapping, owner-UID/draining-upload and native timeout-cleanup gates retain their owners. #534 remains explicitly unreleased under its recorded upstream qualification hold. |
|
Scoped Server public readback PASS after #536: fresh stable manifest SHA256 equals |



The published PHP SDK 3.18.1 now qualifies retained update reads and actual Worker completion-size handling on Server 3.9.1. Select it in the stable manifest and explain the GET/default-wait/null/unknown-key journey, linking the exact-tag SDK guide. The shared reference also still incorrectly refuses native storage-admission settings despite their published 3.9.1 implementation; correct that scoped configuration description.
Evidence: SDK final publication and installed receipt, PHP actual Worker proof, and Server 3.9.1 storage-file controls. Independently checked Packagist source/dist and live portal audit at
ffa67454b99e299624d46dc2c5a4f7eceab5b73f, successful protected registry acceptance 43440828565 and exact-tag portal 43440834913, live guide anchor, and tagged Client/UpdateStillPending/Server storage-consumer source.All seven translations and source hashes are complete. Exact head
eabcb40de6234710d94da7a905f56828fcd645fbpasses the full local Node 24 build for all eight locales, generated-page readback for all 16 changed pages, exact manifest and unchanged installer bytes, translation/code parity, localized links, public boundary and added-source credential/whitespace checks. Manifest SHA2560a8878f4dc1cd92af315d5c41887da1beddd3d20e8efd53b01a7ab1e46a88c36. PHP and Server owners passed the unchanged English source at398d73f9. All 14 current hosted checks and CLI independent source/locale review passed. Merged as127993281e379985fcb3b20d27ca7e0d97543fea; protected Pages deployment 43447139751 succeeded at that source. Live readback passed all 16 public pages plus exact manifest and unchanged installers. Remote branch deletion verified. Docs delivery is complete for this scoped adoption. Existing records shared #212, shared #228 and Server #951 retain their actual owners and wider gates. No full #216, native timeout cleanup, #1206 UID hardening, draining-upload allowance or Cloud production adoption is inferred. Existing Server/Chart/Rust/other artifact selections and installers remain unchanged; Workflow draft #534 is separate.