Repository navigation
Document repeat-last retry delays in options and worker protocol - #549
Conversation
|
Bounded embedded-producer semantics PASS at exact English head I read both changed English files against published Workflow The scheduling snapshot and existing persisted-policy/empty-backoff tests support retaining recorded delays when defaults change. The two prose changes preserve total-attempt wording, executable fences and wire field names. No source or runtime behavior change is implied. This review covers embedded producer semantics and the stated shared policy meaning. Server owns native transport/runtime parity; locale, build, normal review, Pages and live checks remain Docs work. I ran no additional runtime or build. |
|
rmcdaniel
left a comment
There was a problem hiding this comment.
Ordinary source/locale review: PASS for exact 4aba847e4b9e6f7c2a4f8ff2e38f667ccf679d23 against e3ff9f5cf342030237d12e8863d37ae2951c740e.
I read both English changes and all fourteen localized additions in de/es/fr/ja/pt-BR/uk/zh-Hans. Every locale preserves total attempts including the first, five total attempts with four retry delays [1,2,2,2], repeat-last after a short list, and zero backoff for an empty list subject to attempt/time limits. Recorded delays remain authoritative when later defaults or SDK code change. The existing options-page total-attempt paragraphs are untouched; none of this introduces a finite generated default cap or changes a wire field.
Mechanical review verified all 46 head/base Git blobs, all 14 updated English-source hash bindings, and byte-identical executable fences (240 blocks across the sixteen guides). Added inline contract tokens and links match across the eight languages. Both English files are byte-identical to the 90ced514 producer-reviewed source. Scope is exactly the 23 documentation/hash paths, without selector, package, protocol schema or implementation changes.
I also read published Workflow c090506c directly: Activity::backoff(): int|array supplies the documented 120-second final default, and both recorded-policy delay readers select the final list entry after exhaustion while retaining explicit empty-list zero backoff. This source inspection is consistent with the bounded embedded-producer review 6880466391. Server's separate wire-producer review is not replaced by this locale review, and no held Python 2.18 result is promoted.
No blocking finding. I ran no build, SDK, Worker or Server. Normal current-head checks, the remaining producer review and the owner's final rendered/build/Pages/live delivery remain separate gates; this does not close the other shared #219 requirements.
|
Bounded published-native semantics review: PASS for the English additions at I checked the exact published native 3.10 source This approves the added portable list/count/preservation explanation and worker-wire paragraph. Workflow owns the activity-class/default and author-option ergonomics. No new wire field, scalar wire form, default cap, runtime execution, installed acceptance, release or held-path scope is inferred. Locale/build/Pages checks remain separate. |
|
The options-page and worker-protocol retry-delay correction is delivered in all eight offered languages. Reviewed source The final all-eight-locale build and rendered checks of all 16 pages pass, alongside all 11 head checks. All 12 actual-main checks and all six main workflows pass, including protected Pages 43615302300. Fresh public readback passed on all 16 changed pages in eight languages, with complete article text equal to the reviewed build. Selected artifacts, installers, protocol catalog/OpenAPI and canonical model copies remain consistent. The guides now state that short lists repeat their final delay, five total attempts with Live: Options / Backoff and worker protocol, plus de/es/fr/ja/pt-BR/uk/zh-Hans. The merged remote branch is independently absent. This completes the finite Docs options/protocol slice of shared219. No new protocol fields, package/selector changes, runtime qualification or held Python 2.18 generated-default delivery is claimed; the remaining shared219 criteria retain their own gates. |



The options page explained list/scalar backoff overrides but omitted what happens after a short list ends. The worker-protocol reference named the policy fields without defining total attempts or the repeat rule.
Document the existing shipped semantics in both pages and all seven offered translations: repeat the final delay, use zero backoff for an empty list, and preserve recorded policies when defaults change. Five total attempts with
[1, 2]allow four retry delays[1, 2, 2, 2]. Keep the options page’s existing total-attempt wording and all executable examples unchanged. The default through 120 seconds is the embedded activity class default, not a new SDK generated-policy cap.This is the finite options/protocol documentation slice of durable-workflow/.github#219. It changes no protocol field, package, selector, runtime behavior or held Python 2.18 qualification. Shared219 retains its cross-binding requirements and existing holds.
The embedded producer semantics review passes against published Workflow 2.28.1. Its reviewed English files are byte-identical at final locale head
4aba847e. The bounded native Server review passes for the published 3.10 retry implementation at exact4aba847e. All 14 source hashes, unchanged fences, localized schedule tokens and public-boundary checks pass. The independent source/locale review passes at exact4aba847e, including all 14 bindings and 240 unchanged fenced blocks across the 16 guides. All 11 current-head checks, the final all-eight-locale build and rendered checks of all 16 affected pages pass. Normal integration is complete at23446c73with exact reviewed-tree equality. All 12 actual-main checks, protected Pages and fresh 16-page/eight-language public readback pass. See the delivery record. The merged remote branch is absent.