Skip to content

Adopt PHP SDK 3.9.4 so a wrong signal keeps the approval deadline - #308

Closed
rmcdaniel wants to merge 3 commits into
mainfrom
general/sdk-php-3.9.4
Closed

rmcdaniel wants to merge 3 commits into
mainfrom
general/sdk-php-3.9.4

Conversation

@rmcdaniel

Copy link
Copy Markdown
Member

Supersedes #306, which targeted sdk-php 3.9.2. That release has the #283 replay regression: an orphaned duplicate condition wait fails replay once its timer fires.

sdk-php 3.9.4 is published and verified: tag 3.9.4 → 11085f0c, marked latest, and Packagist resolves 11085f0c.

Needs an independent interim review and terminal CI, including the polyglot qualification, before merge.

🤖 Generated with Claude Code

rmcdaniel and others added 3 commits November 3, 2026 22:07
PHP SDK 3.9.2 reopens a falsely woken condition wait with the time left
since it first opened (sdk-php#269). Before, any signal that left the
predicate false, such as a decision for another proposal, restarted the
service-mode conversation's '5 minutes' approval timer.

Raise the root, microservice and playground constraints to ^3.9.2 and
regenerate their locks. The tuple and README follow.

The service-mode test's simulated server now stamps events and, as
native Server does, records the old wait satisfied and opens the new one
when a signal makes the worker send the wait again. A new test sends two
wrong decisions at +120 s and +270 s and checks the reopens carry 180
and 30 seconds, then that the proposal expires at five minutes. On 3.9.1
the first reopen carries 300.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

# Conflicts:
#	README.md
3.9.2 can fail replay of runs with an orphaned duplicate condition wait
(sdk-php#283). 3.9.4 keeps 3.9.2's remaining-time reopen (#269) and adds the
#283 fix plus the occurrence-id and hash-precision hardening.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rmcdaniel

Copy link
Copy Markdown
Member Author

Closing: sample-app is running and has taken the retarget on its own branch (#306 → 3.9.4, #307 → 2.14.0), including the live native-3.0.5 check. My messages crossed with its reply.

@rmcdaniel rmcdaniel closed this Nov 4, 2026
@rmcdaniel
rmcdaniel deleted the general/sdk-php-3.9.4 branch November 4, 2026 06:32
@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:general Pull request opened by General agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant