Repository navigation
Disable APT retries on the remaining networked APT paths - #337
Merged
Merged
Conversation
Three polyglot images run networked apt-get on unpinned parents (php:8.4-cli twice, debian:bookworm-slim), so their APT version is not verifiable. Four workflow jobs run shivammathur/setup-php, which can call apt-get itself, and sdk-children runs playwright install --with-deps on the hosted runner. Write Acquire::Retries "0" before the first networked APT step in each, so the retry-after-redirect precondition of CVE-2026-109518 is absent (as in cli#121, waterline#300, cloud#758). The root and devcontainer images and the Python worker already run the central fixed-Bookworm-APT guard on pinned parents and are unchanged. AptNoRetriesContractTest now requires one protection or the other before APT in every workflow job and image stage. Refs durable-workflow/.github#295 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Member
Author
|
Security PASS at 85f66ec (.github#295). Guards precede every setup-php and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Part of durable-workflow/.github#295 (CVE-2026-109518: APT follows a redirect on retry, then installs a swapped package as root).
An org-wide inventory of networked APT calls found these sample-app paths with neither fixed apt nor retries off:
polyglot/laravel/Dockerfilephp:8.4-cli, unpinnedpolyglot/php_worker/Dockerfilephp:8.4-cli, unpinnedpolyglot/rust_worker/Dockerfile(runtime stage)debian:bookworm-slim, unpinnedci.ymltest,microservice-test;composer-lock-audit.yml;playground-journeys.ymlshivammathur/setup-phpcan runapt-get(repair/extension paths)sdk-children.ymlplaywright install --with-depsrunssudo apt-getChange: each of these writes
Acquire::Retries "0";to/etc/apt/apt.conf.d/99-no-retriesbefore its first APT-capable step. That's aRUNline in the images and a step in the jobs. Same pattern as cli#121, waterline#300 and cloud#758.Already protected and unchanged: the root
Dockerfile,.devcontainer/docker/Dockerfileandpolyglot/python_worker/Dockerfile. They run the centralrequire-fixed-bookworm-apt.shguard on parents pinned by digest (php:8.4.27-cli-bookworm@b3e907a1…, which has apt 2.6.2).Test: new
tests/Unit/AptNoRetriesContractTest.phpchecks two things:apt-get,--with-depsor Brotliinstall-vendor.sh.Controls show the checks catch a late or missing line. I ran it locally in
composer:2.11.0: 4 tests pass, and it reports all 8 paths above when the fix is reverted. The centralqualification_policy.py validatealso passes on the changed workflows.🤖 Generated with Claude Code