Repository navigation
Repeat the final local-activity backoff entry - #296
Merged
Merged
Conversation
Local activity retries used a zero delay once attempts outnumbered the backoff list, so a policy that backs off remotely retried in a tight loop locally. Repeat the final entry instead, matching Server-scheduled activities (durable-workflow/.github#219). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The corpus fixture runs the real local-activity executor and fails on the previous zero-delay tail. Also fix a test line over the length limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local activities retried with zero delay once attempts outnumbered the backoff list, so a retry policy that backs off for remote activities spun in a tight loop locally. Each later retry now repeats the final backoff entry, the same rule Server-scheduled activities follow (durable-workflow/.github#219, decided 2026-11-11; PHP shipped the same fix in 3.13.0).
worker.py: one-line change in_execute_local_activity. The backoff list already carries the policy's maximum-interval cap.tests/test_local_activity_backoff.py: list[1, 2]with 5 attempts sleeps[1, 2, 2, 2](it slept[1, 2]before), and a policy with no list still doesn't wait.🤖 Generated with Claude Code