Repository navigation
Record activity schedule-to-start in run_until() - #298
Merged
Merged
Conversation
run_until() runs activity tasks through _run_until_activity_task, which skipped the schedule-to-start sample that run()'s dispatch path records. Found by an installed check against published Native Server 3.4.0 (#188). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by today's installed check for #188 (published SDK 2.15.1 against published Native Server 3.4.0). Workflow tasks recorded
durable_workflow_worker_task_schedule_to_start_seconds, but activity tasks recorded 0 samples underWorker.run_until().run_until()runs activities through_run_until_activity_task, which never called_record_task_schedule_to_start. Onlyrun()'s_dispatch_activity_taskdid. Native sendsready_age_mscorrectly; this is SDK-only._run_until_activity_task.test_run_until_activity_records_server_ready_age.tests/test_sdk_metrics_contract.py123 passed.Refs #188.
🤖 Generated with Claude Code