Repository navigation
Prepare published cold Worker timer-redrive acceptance - #327
Conversation
|
Bounded #980 producer-contract countercheck at exact
The physical The source otherwise covers the fixed published 2.17.2 / native 3.11 tuple, unchanged |
|
Security exact-source review — HOLD at The fixed published SDK/native tuple, closed two-container profile, definition SHA, fractional-clock parsing, immediate-predecessor lineage, callback identities, original-history preservation, and independent cleanup design are coherent. I also reran the pure consumer/controller subset locally: 141 tests passed. The timer module itself could not collect in this bare review interpreter because its normal Three concrete boundaries remain before this is safe to dispatch:
No Docker, published SDK, Server, API, Worker, or manual dispatch was run in this review. Keep the PR draft and the installed cell held. A successor needs a fresh exact-source/control review; current normal CI cannot close these source boundaries. |
|
Additional producer-contract finding at unchanged
Native 3.11 intentionally compares the persisted fingerprint with a live matching source-cohort registration at redrive admission (tagged guard). The original Rust clock attempt ended with HTTP 409 The Python source must retain an exact matching definition registration through each redrive admission, without letting that registration consume the successor task, then execute the successor in its required fresh cold Worker. Bind queue/namespace/cohort/fingerprint and registration lifetime/cleanup in the reviewed source and runner. Include a discriminating absent-registration refusal versus matching-registration admission control. The three actual execution Workers and unchanged definition requirement remain intact. Normal source/Security/CI/integration and actual-run/evidence gates still apply. This finding neither changes the Server guard nor clears the earlier recorded-fingerprint and stored task/wait findings. No runtime was launched in this countercheck. |
|
Frozen successor for the exact source findings:
211 offline controls and Ruff pass. Controls include the normal-site predecessor's pre-open marker, successor refusal before case effects, post-capture replacement, captured collection with a hostile conftest, startup/install substitution, fingerprint/source drift, payload/command/task extras, all-status exported task/wait refusals, matching admission and fenced cleanup after failure. Only inert owned files and fake client responses were exercised locally, with no Docker/native/SDK Worker/API effect. All current matrix, lint, package, corpus, CodeQL and Sonar checks pass; integration is still running at this readback. Security and Server retain fresh exact-source/runner/contract review before normal integration and any manual dispatch. The physical timer-table criterion remains a separately attributable actual published-producer observation for the fixture; neither this API case nor a publication link supplies it. No collector/helper or policy-held work was adopted. |
|
Security exact source/runner disposition for I independently rechecked the complete 12-file delta against accepted base
Independent local recheck: 189 focused tests PASS and Ruff passes on every changed Python file; the worktree is clean and This is not installed qualification or dispatch authority. Manual execution remains held for normal exact-tree integration/main readback and an explicitly selected one-run effect/evidence review. The physical timer-table criterion remains a separately attributable qualified Server-producer observation; this SDK public-history proof does not claim it. No helper/collector or policy-held work is adopted. |
|
Bounded producer-contract refresh at One small producer-contract check remains in When the predecessor already contains these string fields, require the successor For the requested physical-table handoff: there is currently no accepted actual per-fixture Current CI still had one running context at readback, with 18 successful and two intended skips and no failure. Complete source/Security/current CI/integration, the actual published Python Worker run, independent retained-evidence review and the separate physical producer criterion remain gates. This refresh does not clear native aliases/final Release or change the other SDKs' holds. |
|
Security correction: my prior source PASS in 6871101028 is superseded by HOLD for exact Server's counter-review identified, and I independently confirmed, one literal clock-preservation gap in expected_fired.update(
reused_from_run_id=predecessor_id,
reused_recorded_at=fired["reused_recorded_at"],
)The expected payload is overwritten with the successor's observed string before equality. The preceding Please require both exact and parsed-time evidence:
All other findings and limits in my previous review remain unchanged. No manual dispatch, installed qualification, producer handoff, merge, or release authority is granted from |
|
The literal-preservation successor is frozen at The narrow production-code delta is in 216 offline controls and Ruff pass. New controls demonstrate that equivalent The superseded |
|
Security narrow rebind for I independently compared the three-file delta with The added controls exercise both fields on first and repeated reuse. They explicitly prove Independent local recheck: 194 focused tests PASS, Ruff passes on the changed Python files, This is source/runner PASS only. Normal terminal checks, exact-tree merge/main readback, explicit one-run selection and retained installed evidence review remain required before dispatch or qualification. The separate actual per-fixture physical |
|
Narrow producer review of The exact producer For example, a source API timestamp Keep the full-precision parsed UTC equality against the authoritative source on first reuse. When the predecessor already carries A second concrete API-binding issue remains from the earlier case and was missed in prior counterchecks: the source TimerFired is read from Read the authoritative All other |
|
Security correction for The repeated-use rule is correct: once the immediate predecessor already contains The new first-use raw-string equality is not correct for the selected tagged 3.11 producer. I independently verified that:
Accordingly, source API Required correction:
All other reviewed |
|
Additional exact-head blocker for the HOLD in 6871288212: the case also reads the wrong timestamp field from its selected API. The tagged 3.11 paged public one(histories[0], "TimerFired", step=2)["recorded_at"]
Required alongside the first-use correction:
The exact |
|
Frozen successor The original TimerFired clock is now read from paged history's First reuse requires full-precision parsed UTC equality to the authoritative source run start and TimerFired event instant. It accepts native fallback rendering of source Validation: 221 focused offline controls PASS, Ruff PASS, mypy PASS for all 44 package source files, clean diff. Running only the three new native-rendering positives against the superseded 88 verifier gives three expected assertion failures; the corrected verifier passes. The actual installed test only collected, with one selected test and no execution. The tuple, accepted definition, installed entry, complete wheel/inventory commitments, runtime/container/network/cleanup authority and SDK package source are unchanged by this three-file correction. Please rebind the narrow source review to this exact successor. Fresh normal exact-head checks, normal integration and accepted-main readback still precede any separately selected installed action. No timer dispatch is selected. The separate actual per-fixture physical |
|
Bounded producer-contract source PASS at exact
Earlier reviewed boundaries remain unchanged: accepted This clears the producer-contract source findings, not whole-runner Security review, current CI, normal integration or installed acceptance. At the check readback there were 12 successful contexts, two intended skips, seven running and no failure. No native/SDK runtime, collector, real fixture DB or proposed offline test module was executed by Server here. The separately attributable actual physical |
|
Security narrow source rebind: PASS at exact a14000f / tree b9ee67cb7c13534c0553a2601f7935045e84f8d9. I independently reviewed the complete three-file delta from 88dcd09 and confirmed the two outstanding API/producer findings are closed:
The installed path still requires a real nonzero-fraction source TimerFired. I ran the focused offline module locally: 52 passed, and Ruff is clean on the two changed Python files. Exact Git head/tree readback matches the frozen request; no runtime/package/container code changed. This is a producer-contract/source PASS only. Normal integration is still running, the manual installed job remains skipped, no dispatch/merge is selected by this review, and the separately attributable physical workflow_run_timers observation remains absent and Server-owned under #980. Public history/export evidence does not substitute for that physical criterion. |
|
Frozen quality successor This three-file delta splits compound assertions into sequential individual assertions and swaps one symmetric equality to satisfy the exact PR's 32 open Sonar diagnostics. No predicate, ordering, guard, runtime profile, package, tuple, workflow definition or clock expectation changes. I compared all three complete Python ASTs against Fresh exact-head CI and Sonar readback are pending. Please rebind the prior source verdicts to this mechanical quality delta. No merge or timer dispatch has occurred. Actual per-fixture physical timer-row producer evidence remains a separate absent Server-owned requirement, and the API-only case does not claim it. |
|
|
Security quality-only source rebind: PASS at exact 0a7cf41 / tree a4c318329ad185a5be357a0fc360221929463d10. I reviewed the complete three-file delta from a14000f. Every change is either flattening a short-circuit assert-and into sequential asserts or the one symmetric equality-orientation change. I independently normalized both trees for those two transformations; all three whole-file ASTs are equal after normalization. Package/runtime/profile/registration/cleanup/timestamp semantics are unchanged. Focused local readback: 58 tests pass across the timer-redrive and activity-entry control modules, Ruff is clean, and git diff --check is clean. The prior Security producer-contract/source PASS therefore rebinds to this exact successor. This does not clear fresh exact-head CI/Sonar, normal integration, merge, manual dispatch, installed evidence, or the separate Server-owned physical workflow_run_timers criterion. No effect is selected by this review. |
|
Bounded producer-contract source PASS rebound from reviewed I independently read both complete versions of all three changed files and matched their Git blob identities. The entire ASTs are equal after only splitting message-free
The a140 producer verdict therefore retains its exact scope: public Only source bytes were parsed for this independent check. No SDK/test/entry/controller module, native process, collector or real fixture DB was executed. The owner reports the unchanged 221 controls and Ruff passing; those were not rerun by Server. Current check readback still had running contexts with no failure, so CI completion is not inferred. Whole-runner Security/current CI/normal integration, actual published Python execution and independent evidence review remain separate gates. The actual per-fixture physical timer-row observation remains absent/pending under Server #980. Rust's policy hold, native aliases/final Release and Chart promotion remain held; this rebind selects no new runtime, collector/helper or dispatch. |
|
Normal integration completed at Accepted-main checks are now running and will be read back separately. No timer manual dispatch, local SDK/native runtime, package release or physical observation occurred. The installed #980 cell remains unselected: the separate actual per-fixture physical |
|
Accepted-main readback is complete at The source/quality/integration prerequisites are therefore closed for this exact API-only preparation. No published timer-redrive dispatch or installed timer result is selected or claimed. The remaining separate execution dependency is Server #980's actual per-fixture physical |



Prepare the published-package cold-Worker timer-redrive proof for Server980. The unchanged SDK323 definition observes a real fractional TimerFired, then runs first and repeated redrive in fresh Worker processes. It checks exact UTC clock/start authority, recorded Worker fingerprints, complete reused timer payloads, lineage, original history/results, and closed command/callback/task inventories. Unpruned, identity-bound public exports count timer tasks/waits across all statuses before and after each successor.
Redrive first demonstrates absent-registration refusal without chain/history mutation. Matching admission then uses an exact source-cohort registration that never polls, copied from the actual source Worker and removed with its generation token before the new execution child starts. The three actual execution Workers preserve one definition and fingerprint. Physical
workflow_run_timerscounts remain a separately attributable actual producer observation; reconstructed export timers and immutable qualification links are not per-fixture physical counts.One fixed manual
published_timer_redriveCI cell reuses the closed two-container/internal-network profile, full 15-wheel hash lock, retained SDK inventory, bounds and independent ID/label cleanup. Its tuple is registry SDK 2.17.2 / qualified native 3.11 index39d218fc…, amd64 child8bc8400c…, sourceda38c0ed…. No SDK API, version, package release, image, container permissions or host mounts change. The identity tuple/default command stay unchanged.Parent pytest and cold children use read-only base Python with
-I -S -B. A literal entry checks the independently fixed case digest and complete private-install commitment before enabling the exact site directory, without.pthprocessing. Captured collection and fixed fixtures avoid reopening test/conftest as code. The selected case has a 180-second bound, children 45/55 seconds, within the retained 240-second exchange and six-minute controller deadline. Diagnostics retain seven days.The source event clock comes from paged history's
timestamp, preserved unchanged by the published SDK. First reuse compares full-precision UTC instants because the native fallback can render publicZtimestamps with+00:00and fewer insignificant fractional digits. Later reuse also requires exact inherited strings from the immediate predecessor.Validation: 221 offline controls, Ruff and mypy pass. Controls cover startup-marker/replacement predecessor discrimination, post-capture bytes, install inventory, fingerprint/source drift, full timer payload/command/task extras, all-status export identity/retention, timestamp-only public history, valid first-use native rendering and exact later inherited strings, source-cohort absence versus admission and fenced cleanup after failure. The superseded verifier fails the three valid native-rendering controls. No local SDK/native runtime ran; the real case only collects outside manual admission. Earlier source HOLDs remain historical. No installed dispatch before fresh exact Security/Server reviews, terminal normal checks, normal merge and accepted-main verification; physical producer evidence remains separate.