Repository navigation
Confine the remaining CI and perf downloads (#677) - #1159
Merged
Merged
Conversation
- kubernetes-validation.yml checks kind v0.23.0 and kubectl v1.29.9 against the projects' published SHA-256 sums and restricts the downloads to HTTPS. - The native corpus's dw.phar download is restricted to HTTPS, including redirects; its digest was already checked. - The PHP-only Octane perf experiments (FrankenPHP, Swoole, OpenSwoole) are removed with their Dockerfiles, whose PECL and extension downloads bypassed the checked CA stores, along with their overlays, probes, soak variants, the prebuilt FrankenPHP transfer and the Composer sink rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Security review: PASS (head
|
rmcdaniel
enabled auto-merge
November 12, 2026 01:55
Member
Author
|
On the dw.phar recommendation: both fetchers already check that digest before anything runs it. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #677, following its 2026-11-11 triage plan.
Change
kubernetes-validation.yml: kind v0.23.0 and kubectl v1.29.9 are checked against the projects' published SHA-256 sums (1d86e306…and7b0de246…), with--proto =https --tlsv1.2. I confirmed both sums against the downloaded bytes.native-image-corpus.sh: thedw.phardownload uses--proto =https --proto-redir =https. Its digest was already checked, andfetch-parity-cli.shalready restricted protocols.pecl install/install-php-extensionsdownloads bypassed the checked CA stores. The PHP Server they measured is retired. Removed with them: the three Dockerfiles, their compose overlays and isolation probes, the soakhttp_variantoptions and branches, the prebuilt FrankenPHP image transfer inrun-vultr-soak.sh, and their 6 Composer sink inventory rows. The Apache, nginx-fpm and apache-event-fpm variants are unchanged. Perf docs now note the removal.Tests
server_soak_test.py(28) andvultr_soak_cleanup_test.py(11) pass. The Vultr tests run the soak script, so I ran them inside bwrap with no network, no Docker socket and a tripwire over/usr/bin/docker. A removed variant is refused before any provider request.composer_trust_test.py(23) andNativeImageCorpusTest.mjs(9) pass.bash -npasses on both soak scripts.🤖 Generated with Claude Code