Repository navigation
Report open-run legacy version usage in native Server - #1221
Conversation
|
Concrete native compatibility finding: the proposed The native route is therefore |
|
Security source review: HOLD on exact The distinct Two concrete blockers remain:
The namespace predicates are closed on both run and instance namespace; MySQL uses binary comparisons, PostgreSQL uses deterministic exact equality plus C ordering, and SQLite uses binary/default ordering. Missing/pruned/gapped/unsupported histories remain unknown, counts precede state filtering, and application payload fields are not selected. I found no separate tenant-leakage issue in the reviewed query. |
|
Bounded #220 source parity review at exact
The revised top-level |
|
Exact source The native prefix correction recognizes The source check ran November 14, 11:19:45–11:20:38 UTC, using the cached pinned Rust 1.99 image, 2 CPUs / 8 GiB / 512 PIDs, offline/read-only captured source and public registry, private target/temp/logs, with two finite 900-second commands. Captured full container Current-head full backend/corpus/required CI and renewed exact Security/Workflow source review still gate merge. Security's earlier HOLD is not cleared by this local result. This establishes neither published endpoint availability nor downstream CLI/Waterline acceptance and changes no #980/#1204 or promotion gate. |
|
Security whole-head HOLD for exact The prior cursor and route findings are fixed: the cursor now has a domain-separated HMAC verified before JSON decoding, and the distinct
The HMAC/route/native ordinary-prefix corrections remain accepted. Backend/corpus/CI gates remain separate; no runtime or release action is requested. |
|
Security whole-source PASS for exact Both findings from 6876578856 are closed:
The previously accepted domain-separated cursor HMAC, safe route, exact response/count bounds, and Workflow |
|
The three bounded parity findings are corrected at All 15 unit controls and 10 SQLite HTTP cases pass on that captured source. A private counterfactual using the earlier Current-head backend/corpus/required CI and renewed exact Security/Workflow source review remain the merge gates. No published availability, installed consumer result or promotion is inferred. |
|
Bounded producer parity review PASS at exact
Native |
|
At exact The earlier reader's four causal failures and the bounded Workflow parity PASS remain attributable to their exact source. Full current-head native backend/corpus/required CI and renewed Security review still gate merge. No skipped backend-only library case is counted as a pass, and no publication/consumer acceptance is claimed. |
|
Security review of current exact
Either reject replay-provenance fields as unsupported under v1, or add them to the normative contract and require both-or-neither with a nonempty exact run ID and the producer's canonical valid recorded clock. Add direct unit and HTTP/storage controls for lone, wrong-type, blank, and malformed provenance, including a valid redriven-marker positive if the pair is admitted. The safe distinct route, operator/admin namespace admission, HMAC-before-parse cursor, exact binary/C joins and keyset comparisons, strict prefix/event-kind/history-contiguity handling, marker budget, ownership/import fail-closed behavior, and the capability-corpus successor otherwise match the reviewed boundary. Current backend/corpus/CI remain separate gates and do not clear this source finding. |
|
Security HOLD on exact cb4e29f, narrowly scoped to the normative contract pin. The implementation-side findings are closed: the route is distinct; operator/admin and namespace middleware applies; cursor HMAC is domain-separated and verified before body parsing; namespace/type/run joins and keyset ordering are exact-collation bound; unsupported owner/history/event/marker formats remain unknown; and the complete reused-marker pair is checked on every marker before classification. However, both the Server guide and OpenAPI still call Workflow 9af1eb53f698f8dd764dfd7841c1851d79555b9d the shared normative v1 contract. That exact document does not define reused_from_run_id or reused_recorded_at. Its known marker-field list ends at task, and it says unknown marker extensions require a reader upgrade and remain unavailable. cb4 instead treats those two fields as known and can classify the actual redriven marker current. Thus the exact source currently cites a normative schema that says its positive is unsupported. Rebind the links to the final reviewed Workflow successor that defines the complete pair, exact source-ID constraints and explicit-offset 1..9-digit RFC3339 clock, and add the corresponding fields to the shared schema if it owns the closed response/marker shape. Preserve a causal assertion that the predecessor pinned document lacks the fields and the successor contains the exact admitted pair. No backend/CI/runtime PASS is inferred; current full gates remain separate. |
|
Security source PASS for exact c1ebf5a. The only cb4 successor delta is the two immutable normative links, both now pinned to Workflow 30341b139323c4bf3fa26a34c2c562f88c075bbe. I independently read that exact blob: it defines both-or-neither reused_from_run_id/reused_recorded_at, a nonempty bounded source run identity, an explicit-offset RFC3339 instant, runtime-specific precision, history_invalid for malformed/incomplete pairs, and no retained-string rewrite. That aligns with native c1 validation and its 1..9 fractional-digit producer format. The shared response schema blob remains bf87b18853363219c325cbae11f4fa4583ab68df and does not own marker payload internals. This closes the prior normative-pin HOLD and the earlier implementation findings. Full current-head library/backend/corpus/CI completion remains an independent integration gate; no runtime or promotion verdict is included. |
|
Security source rebind PASS for exact The version-usage implementation, tests, HMAC/cursor behavior, exact-collation queries and Workflow Fresh current-head backend/corpus/CI remains the integration gate. No runtime, release or promotion scope is inferred. |
|
Security test-only rebind at exact The production prefix is byte-identical to reviewed Focused/current-head test and complete CodeQL/backend integration remain separate merge gates; no runtime or promotion scope is added. |
|
Bounded Workflow v1 source-parity rebind PASS at I read the reader successor to the previously reviewed The closed retained-kind registry, exact owner/namespace/history joins, unknown accounting, signed query-bound cursors and collision-free route retain the earlier parity fixes. I also read the fresh-random-key cursor controls. No new shared-interface finding. This is source review; I did not execute the native tests, and current whole-head CI/backend/Security, publication and consumer acceptance remain the Server owner's gates. |
|
Current-head integration HOLD on exact f944e74 is a concrete test-fixture defect, not a new production-reader finding. The new pruned_missing_prefix_and_conflicting_history_remain_unknown control inserts history ID Use a valid <=26-byte unique fixture ID, preserve the late StartAccepted placement and last_history_sequence increment, then rerun the exact current whole-head backend matrix. The current artifacts do not execute the intended classifier assertion on those backends, so they remain NONPASS. The production source/test-key Security PASS at 6877840351 is unchanged; this finding is scoped to complete integration evidence. |
|
Bounded fixture finding CLOSED / source rebind PASS for exact The complete delta from reviewed I did not rerun the backend matrix locally; the reported cached MariaDB and PostgreSQL 17 endpoint passes and current exact-head full CI/CodeQL remain separate integration evidence. No runtime, promotion, or release scope is added. |
|
|
Final exact-head Security/integration disposition: PASS for Independent current readback confirms 64 terminal contexts: 63 The final successor remains exactly the reviewed source: the only The earlier backend failures remain correctly NONPASS and are superseded only by these fresh exact-head backend results. This closes the source and current integration review for PR #1221. Published endpoint availability, CLI/Waterline consumer acceptance, release/promotion, #980 and #1204 remain separate. |



Open runs without a version marker currently have no fleet read that keeps them distinct from runs which recorded a current decision. This adds
GET /api/workflow-version-usageandcapabilities.workflow_version_usage, using Workflow #1146's v1 contract for namespace-scoped legacy/current/unknown counts and paged records.The query reads existing run/history rows in one read-only repeatable snapshot. It preserves missing, pruned, incomplete, unsupported, malformed and conflicting evidence as unknown, validates signed 32-bit decisions and ranges, and uses exact identity comparisons on all three backends. Counts precede state filtering; opaque query-bound cursors traverse ascending run IDs under the first page's fixed upper bound. Each page remains a live observation. No workflow code, argument/result/memo or external payload fetch is involved.
Regression coverage includes recorded boundary decisions, missing-marker safety, invalid ranges, history gaps and marker budget, open/closed filtering, all-state counts, named namespaces, case-sensitive type identity, query/cursor validation and keyset admission bounds. OpenAPI and native usage documentation describe the capability, errors and live paging limits.
Validation at final
e1729e222fd56e7d8b3181663969df76a49d38f9: all 63 current-head checks succeed, with one declared skip, including CodeQL, feature qualification and the complete native/backend/corpus matrix. Focused validation passes all 17 reader/cursor unit cases and 12 HTTP cases on SQLite, MariaDB and PostgreSQL 17. The endpoint cases include malformed reuse refusal, an actual native redrive writer/query positive, unknown ownership/history, and authenticated pagination. Cursor tests use fresh OS-random keys and retain wrong-key, unsigned and tampered-bound refusal. Independent exact-source Security review and Workflow shared-contract parity review pass. Published endpoint availability and CLI/Waterline acceptance remain separately attributable.Implements the native source portion of #1220 and durable-workflow/.github#220. The shared contract is Workflow #1146 at
30341b139323c4bf3fa26a34c2c562f88c075bbe. No marker producer, storage schema, replay behavior, #980 qualification, #1204 capture, release alias or promotion changes are included. #1220 remains open through publication and consumer follow-through.