Repository navigation
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI's standalone native development runtime cannot compile on Windows because the library imports Unix filesystem traits/flags and calls
geteuideven when storage admission is disabled. This isolates the existing trusted descriptor reader behindcfg(unix)and leaves disabled admission available on every target. Configured observations on unsupported platforms return unavailable/fenced through the existing admission path; no replacement ownership policy or weaker file reader is introduced.The Unix descriptor/UID/mode/no-follow/nonblocking/bounded-read implementation is unchanged. Tests retain its trust checks, add a portable disabled-admission assertion and cover configured fail-closed behavior on non-Unix targets. The storage-admission guide states the supported boundary.
Validation: all five targeted Unix admission tests pass, including ownership, symlink/FIFO/mode/depth/freshness checks and disabled admission. The descriptor-reader function body is byte-identical to the base. The consuming CLI Windows test is still required; independent source/security review and ordinary current CI remain gates. This source dependency is a development rebuild; it does not qualify a published Server image or broaden native-image platforms.
Refs #1222. Fixes the Server library blocker for durable-workflow/cli#161 / durable-workflow/cli#160. No admission collector, Windows UID trust, immutable tag, #980/#1204 or release/promotion path changes.