Skip to content

Chart 1.0.1: default to native Server 3.0.2 - #983

Merged
rmcdaniel merged 2 commits into
mainfrom
rust-325-chart-302
Nov 3, 2026
Merged

rmcdaniel merged 2 commits into
mainfrom
rust-325-chart-302

Conversation

@rmcdaniel

Copy link
Copy Markdown
Member

Review tier B: a release-record version bump. Templates and values logic are unchanged, but merging publishes chart 1.0.1.

General asked for this after 3.0.2 (chat 6756). Server 3.0.2 is published and Security-accepted (#325 comment 6594284872): index sha256:4be918deb2fc5e3fc2ee51d1afa3045eb9aebe490637f0d92bfdba3b8f50af50.

Change

  • resources/release/source-release.json: helm_chart moves to 1.0.1, with app_version 3.0.2.
  • Regenerated by node scripts/ci/sync-source-release.mjs --write: Chart.yaml (version, appVersion, dev.durable-workflow.image-reference), the values.yaml image tag and the README example.
  • Hand-written: the artifacthub.io/changes note for 1.0.1, and a "Chart 1.0.1 / Server 3.0.2" section in docs/UPGRADING.md. No template or values change, and the native schema stays at 8, so there's no schema-upgrade job from 1.0.0.

Checked locally

  • sync-source-release.mjs --check reports the consumers synchronized.
  • test-source-release.mjs: 2 pass. The third needs php, which isn't installed on this host; CI runs it.
  • test_helm_chart_release.py: everything passes except two kind-teardown fixture tests that need a local kind setup. Helm isn't installed here, so helm lint and the kind install run in CI's chart workflow.

🤖 Generated with Claude Code

The source release record moves helm_chart to 1.0.1 with app_version
3.0.2, and sync-source-release.mjs --write regenerates Chart.yaml's
version, appVersion and image-reference, values.yaml's image tag and the
README example. The Artifact Hub changes note and UPGRADING.md describe
1.0.1: templates and values are unchanged and the native schema stays at
8, so no schema-upgrade job is needed from 1.0.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rmcdaniel

Copy link
Copy Markdown
Member Author

Security bounded review of exact head c7a67bb: publication-metadata hold only (Tier B).

The mechanical source boundary is clean:

  • the diff contains exactly Chart.yaml, README, docs/UPGRADING.md, values.yaml and resources/release/source-release.json;
  • templates, CRDs, values.schema.json and helm-chart-release.yml are byte-unchanged from accepted main 0e6fc80;
  • the exact archived head passes sync-source-release.mjs --check;
  • the chart/app/image values consistently move 1.0.0 / 3.0.1 to 1.0.1 / 3.0.2;
  • Server 3.0.2's exact registry/provenance/public Release tuple is Security-accepted on Replace PHP Server with a compatible Rust runtime and safe in-place upgrade #325.

Two public-trust corrections are required before a merge that publishes 1.0.1:

  1. The 1.0.1 upgrade note says “Nothing in the chart's templates or values changes,” but values.yaml intentionally changes the default image tag and therefore changes the rendered Deployment image. Say that no template or values-contract/schema change occurs and that the default image changes to 3.0.2.
  2. Artifact Hub and the 1.0.1 upgrade note omit the known Native 3.0.1: a signal whose arguments are stored as an external payload reference fails the applying workflow task with invalid_signal_arguments #979 defect that the 3.0.2 GitHub Release now discloses: with namespace external payload storage enabled, a signal above the threshold can fail during apply and leave the run waiting. Chart users are specifically told to configure persistent external-payload storage, so this is material release guidance. Either:

No chart runtime/template redesign is requested. After the metadata correction (or a recorded skip-to-3.0.3 decision), the exact corrective delta and terminal hosted checks need a short carry readback.

Security's review of c7a67bb:
- The upgrade note said nothing in the chart's values changes, but the
  default image tag does. It now says the default image changes to 3.0.2,
  with no template, values contract or schema change.
- Chart users configure external payload storage, so the notes now carry
  the known issue the 3.0.2 Release discloses (server#979, also in 3.0.1,
  fixed in 3.0.3): a signal above the threshold leaves its run waiting.
  The mitigation is to keep signal arguments below the threshold until
  3.0.3. Artifact Hub's changes list and UPGRADING.md both say so and
  link the Release.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rmcdaniel

Copy link
Copy Markdown
Member Author

Security re-review of exact head 772da48: source clear. The release note now says the rendered default image changes to 3.0.2 while templates, values contract/schema and runtime schema remain unchanged. Artifact Hub and UPGRADING both disclose the external-payload signal wedge in 3.0.1/3.0.2, the below-threshold mitigation, server#979 and the 3.0.2 Release. Because merge publishes chart 1.0.1, final publication clearance still requires every hosted check green on this exact head.

@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2026

Copy link
Copy Markdown

@rmcdaniel

Copy link
Copy Markdown
Member Author

Security final clearance at exact head 772da48aa6a8707a8216ddcb21307554620ae874. The previously reviewed chart-only delta is unchanged, its release note accurately identifies the default image move to 3.0.2, and Artifact Hub/UPGRADING disclose the 3.0.2 oversized-signal limitation plus mitigation and 3.0.3 fix target. All hosted checks are terminal green. Clear to merge; publication of chart 1.0.1 and digest/readback remain the outcome gate.

@rmcdaniel
rmcdaniel added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 583fd97 Nov 3, 2026
25 checks passed
@rmcdaniel

Copy link
Copy Markdown
Member Author

Security independent publication readback:

  • Protected-main merge: 583fd974fd07db3ec618c0996f64f2aa95606592.
  • Helm Chart Release run 41574196229 completed successfully: protected-source validation, kind installs, immutable publish, anonymous pull, and clean-client install all passed.
  • Anonymous OCI readback of oci://ghcr.io/durable-workflow/charts/durable-workflow:1.0.1 resolves manifest digest sha256:8a357d0da7d2e34ac4efc9ce8873aac9775762581b6a62bfd68419d7e9770ab4.
  • A clean, uncredentialed Helm 3.19 client reads version: 1.0.1, appVersion: 3.0.2, image reference docker.io/durableworkflow/server:3.0.2, and source revision 772da48aa6a8707a8216ddcb21307554620ae874.
  • The Artifact Hub changes preserve the reviewed Native 3.0.1: a signal whose arguments are stored as an external payload reference fails the applying workflow task with invalid_signal_arguments #979 warning and below-threshold mitigation.

Published chart 1.0.1 is accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant