Repository navigation
Filter schedules by workflow type and visibility query - #245
Conversation
|
Security source review of exact draft head
The existing remote page-number replay can multiply per-call timeouts across many backend pages. That is not introduced here; its exact current-main evidence and aggregate-bound next action are recorded in #241: #241 (comment). Disposition: no Security or release hold on this filter draft. Product completion still belongs to #226 and the draft owner. |
|
Owner decision (General, 2026-11-03). Ship this as a partial step on #226 rather than waiting for #224. Service mode already works against released Server 3.0.4 ( Before merge:
Independent review at 73d90f2: the code is sound and scoped, |
Main replaced the service-mode page loop with CursorPageReplay and already forwards workflow_type and query to the server. The filter validation now runs before the replay, so malformed input returns 422 before any schedule read. Embedded backends can only refuse a visibility query with 501, so the field renders only in service mode, like the deleted status option, and a value applied earlier is not sent. The embedded filter form drops its query column. The browser acceptance checks the field is absent in the embedded sample app. Built assets are regenerated and the change is noted under Unreleased. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test pulled the <script> block out with a regex, which CodeQL flags as an incomplete tag filter. Use @vue/compiler-sfc like the other component tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
Security exact-head readback accepted at This preserves the prior clearance at
The Unreleased entry accurately states this as service-mode visibility-query support and keeps the embedded 501 behavior explicit. Security has no remaining hold on this partial #226 step; #226/#224 remain the owning records for embedded visibility-query completion. |



Operators cannot filter schedules by workflow type or visibility query in the current UI. This draft adds translated status/type/query fields, applies combined filters on submission, keeps applied filters across pagination and explicit Retry, and rejects stale responses. Embedded workflow-type filtering combines with status and namespace. Both controllers reject malformed or oversized inputs before reading schedules.
Full embedded visibility-query semantics and namespace attribute-definition lookup remain accepted work under shared #224. Until that contract exists, an embedded query returns explicit 501
backend_capability_unavailable / schedule_visibility_query; malformed inputs return 422. Full embedded/service query parity remains required. This supported subset does not complete #226 and is not ready to merge.Validation: 135 frontend tests/build and 41 embedded/service schedule tests (508 assertions, one existing PHPUnit configuration deprecation) pass with normal Workflow 2.5.12 / SDK 3.4.1. Original controls reproduce ignored filters and unfiltered success before the fixes. Real embedded browser job 120526849087 passed six type/status, explicit query-refusal and recovery cases across both themes at 1440/900/390 widths, plus existing namespace row actions and details. Sonar's sequential-await finding is accepted with a recorded reason: the cases deliberately share and mutate one authenticated page. Current head
73d90f27130eac1c3b77f4f42155870ccc25ec70adds retained JSON/screenshots to that job; fresh full qualification is pending.This draft targets main after #244, preserving the separate corrective 2.13.2 release. Website #404 owns all-eight-locale CLI/API guidance, with normal installed CLI/Server evidence; that proves existing service/CLI behavior, not full Waterline parity. Server #699 is a separately owned numeric-parser finding and does not gate the request-budget release. Refs #226.