Skip to content

Label redrive lineage links as Redriven from / Redriven as - #259

Merged
rmcdaniel merged 2 commits into
mainfrom
feat/redrive-lineage-labels
Nov 3, 2026
Merged

rmcdaniel merged 2 commits into
mainfrom
feat/redrive-lineage-labels

Conversation

@rmcdaniel

Copy link
Copy Markdown
Member

Part of durable-workflow/workflow#864 (Waterline lineage).

Run detail showed a redrive link as Parent and Child. With durable-workflow/workflow#1008, the engine reports redrive links from typed history with link_type: redrive. This PR labels them:

  • Redriven from on the successor run, which points at the failed source.
  • Redriven as on the source run, which points at the successor.

Both labels are translated in all eight locales. Other link types keep their current labels.

Depends on durable-workflow/workflow#1008. Until a release includes it, links have no redrive type and keep the old Parent/Child labels, so nothing breaks.

Tests

  • New case in tests/Frontend/run-observation.test.mjs. It covers both directions, the German translation, and the unchanged child_workflow label.
  • Full frontend suite: 144 pass, 0 fail (node --test tests/Frontend/*.test.mjs, Node 22 container).
  • Counterfactual: the new test fails against main's flow.vue, which renders Parent:source,Child:successor.

🤖 Generated with Claude Code

Run detail showed a redrive link as Parent and Child. The engine now
reports redrive links from typed history with link_type redrive, so
label them Redriven from on the successor and Redriven as on the source,
in all eight locales.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2026

Copy link
Copy Markdown

@rmcdaniel
rmcdaniel marked this pull request as ready for review November 3, 2026 22:15
@rmcdaniel

Copy link
Copy Markdown
Member Author

Security exact-head review: clear to merge at dd994dff69f616001676db8ede2b831acb07034d.

Independent readback:

  • the only runtime branch is exact link_type === 'redrive', with Redriven from for the parent/source direction and Redriven as for the child/successor direction;
  • every other link type retains the existing continued-as/from or Parent/Child behavior;
  • all eight locale catalogs carry both keys, and the built chunk contains the new translations;
  • the generated app/chunk references and mix manifest are internally updated;
  • the focused test binds both redrive directions, a non-English catalog and the unchanged child-workflow fallback;
  • the CHANGELOG accurately says the behavior is dormant until Workflow reports typed redrive lineage from #1008;
  • git diff --check is clean and the exact head has 35 successful checks, 2 intended skips, no failure or pending check, and GitHub reports it mergeable.

The dependency remains product-ordering only: do not claim the labels are live until workflow#1008 ships. Merge only this exact SHA; return for review if the head changes.

@rmcdaniel
rmcdaniel merged commit 05be241 into main Nov 3, 2026
37 checks passed
@rmcdaniel

Copy link
Copy Markdown
Member Author

Merged on Security's clearance of exact head dd994dff69f616001676db8ede2b831acb07034d (6617091292).

  • Merge commit: 05be241dcd04230c61a60fff109ee9075a84a9a2. Its parents are prior main b0b278a8 and dd994dff.
  • The merge tree equals the cleared head's tree (24a1d382), so there's no file delta.
  • The live labels depend on Report a redrive link as typed lineage workflow#1008. Until a release includes it, no link reports link_type: redrive, and the old Parent/Child labels stay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant