Repository navigation
Support schedule visibility queries in embedded mode - #290
Merged
Merged
Conversation
Embedded Waterline refused every schedule visibility query with 501. Workflow 2.21.0 added ScheduleVisibilityQuery (workflow#1036), so when the installed Workflow has it, the schedule list now parses the query with it and applies its equality predicates together with the status, workflow type and namespace filters. Only the parser is used because the Workflow builder needs one namespace and a cluster-wide Waterline lists them all. Unsupported queries get 422 with Workflow's reason. Older Workflow installs keep the 501 refusal. The backend advertises schedule_visibility_query, and the schedules screen shows the query field whenever the backend supports it rather than only in service mode. CI runs the schedule controller tests against published Workflow 2.22.0; the development pin (2.20.3) covers the refusal path. Refs #226. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
CI: 34 checks pass, including the new Published Workflow 2.22.0 schedule query integration (23 tests, 296 assertions; the helper path runs). The 5 failures (mssql, browser budget, both Responsive browser jobs, and the gate) all stop at |
Add the organization guard from durable-workflow/.github#355: the public-boundary check refuses any tracked .claude/settings.local.json at the root or below, printing only the path, and .gitignore covers both forms. Content scans are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With ScheduleVisibilityQuery available on the host (Workflow 2.21+), embedded mode now answers schedule visibility queries, so the visual check must expect the field instead of asserting it is hidden. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embedded Waterline refused every schedule visibility query with 501, so the query field was service-only. Workflow 2.21.0 added
ScheduleVisibilityQuery(workflow#1036). This PR uses it when the host has it.Workflow\V2\Support\ScheduleVisibilityQueryexists, the embedded schedule list parsesquerywith it and applies its equality predicates together with the status, workflow-type and namespace filters. Only the parser is used, because Workflow's builder needs exactly one namespace and a cluster-wide Waterline lists them all. Unsupported queries return 422 with Workflow'sreason(for exampleunsupported_schedule_visibility_predicate). Older Workflow keeps the existing 501backend_capability_unavailable / schedule_visibility_query.backend.capabilities.schedule_visibility_queryis true in service mode, or when the helper is installed.--embedded→--no-query.V2SchedulesControllerTest. The development pin (2.20.3) covers the refusal path.public/assets; changelog entry under Unreleased.scripts/check-public-boundary.shrefuses any tracked.claude/settings.local.json(root or nested, printing only the path), and.gitignorecovers both forms.Local checks:
V2SchedulesControllerTestpasses on Workflow 2.20.3 (23 tests, 2 skips) and on 2.22.0 (23 tests, 1 skip), and all 173 frontend tests pass. Rebuilt assets differ only in the expected three files.Closes #226.
🤖 Generated with Claude Code