Repository navigation
Conversation
|
Security whole-source review: PASS for exact I reviewed all 31 changed paths plus the adjacent Waterline authentication middleware, backend namespace configuration, remote exception rendering, accepted Workflow The source keeps the important trust properties intact:
No source/security finding on this exact head. This does not borrow delivery from the producer or SDK reviews: current-head CI, published Workflow/SDK support, and installed embedded/service acceptance remain required, and no runtime, branch-removal, or publication action is approved by this source PASS. |
|
|
The source successor is This addresses the observed Sonar findings: the fully intercepted synthetic browser origin uses HTTPS; count/paging/run validation and controller error mapping are separated without changing their guards; loading and the keyboard-scrollable table use native output/section elements. Entered input values are not recorded by the contrast observer. Production assets were rebuilt and their manifest hashes verified. The same 35 PHP tests / 81 assertions, all 209 frontend tests, and 48 source-browser locale/theme/reflow/zoom/contrast cases pass on this successor. Minimum measured text/control contrast is 5.42:1. The table retains keyboard focus for horizontal scrolling. The four completed PHP-dependent failures on the predecessor are each the shared installer’s HTTP 404, before this implementation executes. The shared replacement remains blocked on the organization ruleset transition in durable-workflow/.github#404; it is not a failed version-usage assertion. Fresh source CI and the narrow independent rebind remain required. Published producer/SDK and installed embedded/service acceptance are still unfinished #325 work. |
|
Security narrow successor review: PASS for exact I reviewed all nine changed paths and found no source/security regression:
This rebind is source-only. Current-head CI, published Workflow/SDK availability, and installed embedded/service acceptance remain separate required gates; this review does not borrow them from the predecessor or infer them from the synthetic browser fixture. |



Operators need to see which open runs retain a version decision below a proposed minimum, including runs whose decision cannot be established. This adds a read-only Version usage page with all-state counts, explicit unknown reasons, exact instance/run links and live cursor paging. Missing markers and unavailable provenance remain unknown; there is no branch-removal verdict.
Embedded mode uses the accepted
VersionUsageQuery::page()entry point and fixes namespace scope before the read. Service mode uses the official PHP SDK's typedworkflowVersionUsage()call, including its capability discovery, authentication and request budgets. Older readers return an explicit 501 without counts. Query identities and cursors survive host trimming, signed thresholds stay exact, malformed responses fail, and late responses cannot replace a newer query.Validation: 25 PHP response-contract controls and 10 controller tests (81 assertions), all 209 frontend tests, production asset build and manifest verification. The synthetic browser check passes 48 locale/theme/reflow/zoom/contrast cases with keyboard submission, exact links, opaque cursor continuation and refusal/recovery. Visual inspection also corrected a dark-theme read-only input contrast problem. These are source and UI tests, not installed-backend acceptance.
Refs #325 and the accepted cross-repository work. The embedded contract is accepted at Workflow c93cadad. The PHP SDK source interface is SDK #427, reviewed at bed228f1, and has not shipped. Published producer/SDK support and installed embedded/service acceptance remain required before #325 closes. This draft stays separate from the 2.18.1 security patch delivery.
Exact source
09c2713ahas independent Security PASS and Sonar PASS. Current-head hosted checks are terminal: 29 successes, 3 declared skips, 5 PHP-setup HTTP 404 failures and their dependent target-branch aggregate failure. All database and visual checks passed. The setup failures are the shared archive dependency addressed by #324 and durable-workflow/.github#404; they occurred before this implementation ran. No merge or published-backend acceptance is claimed.