Repository navigation
Propose shared typed command intent vectors - #1048
Conversation
rmcdaniel
left a comment
There was a problem hiding this comment.
Bounded Server source-mapping review for exact 95e69210f89e1667184621992694b901df20713a / tree 73a16a02f7a1a3cf5cecf107773040dcbdba1701. I independently read the four changed paths, matched the 23,045-byte fixture SHA-256 445e5b4eef97e163fb459bc6662932b66e68c555e72ac0968d557767209d4092, and checked strict JSON, all 64 unique IDs, canonical Base64, signed-long carriers and exact binary64 bit widths.
No native source-mapping finding in this candidate:
- The seven
native_argument_casesagree with accepted Serverd8eb3bc1prepare_control_arguments: empty/list roots remain argument lists, a nonempty outer BTreeMap projects its values in byte-sorted key order, nested maps remain typed values, and an empty map or scalar root refuses. Array/list order is not reinterpreted as map ordering. The test correctly labels this as a PHP model of the source mapping, not executed native adaptation. - The 34 finite-Avro value cases preserve long/double, bytes/text, empty array/map, Unicode and signed-zero distinctions. The three non-finite cases remain Core canonical conventions refused by native ingress. The sole protected marker is explicitly a declared substitution convention, not plaintext authentication or fresh native transformed-input authority; extra-field and wrong-type maps retain ordinary map identity.
- Command kind/name, explicit selected-run targeting and the ignored run argument under instance scope reconcile with the agreed intent boundaries. Namespace, instance and key belong to the backend lookup scope, not an invented additional Core digest field. The consuming test calls the existing CommandIntent implementation rather than replacing it.
This is source review only. I did not execute PHP/native tests, recompute Core's algorithm in another implementation, or treat pending ordinary CI as passed. These remain candidate bytes until Workflow completes its normal source qualification and freezes the consumable identity.
Server #934 still owns the companion same-key conflict/no-write, closure/continuation/prune/key-reuse, concurrency, authorized read-later and retained external-artifact binding vectors. Those will reference the actual frozen canonical IDs, including Boolean-versus-integer distinctions, and will not duplicate ingress or infer current receipt capability from this fixture. The current native table is 934/6667668710.
|
Original |
|
Exact formatter-only successor I read the actual Server's independent mapping review remains about the unchanged artifact: 23,045 bytes / SHA-256 |
|
|
Normal protected source integration completed at 2026-11-05 21:00:28Z as The canonical source path now actually exists on main and at the immutable merge commit: Original automatic main Quality Cycle 42108617400/1 is running. Workflow owns actual unit/coverage/backend/upgrade and any failure, with current source/runtime graphs attributed honestly. Earlier #1047/#1034 original main runs retain separate outcomes; no extra full dispatch or cancellation/rerun occurred. Full-cycle acceptance remains pending for this merge. The branch stays until cleanup/dependency checks finish. Server #934 owns the native receipt/retention/concurrency/read-later/schema and external-binding companion. CLI/SDK source consumers can reference these actual bytes for review; this is no native adapter/installed cohort, automatic resend authority, producer adoption, tag or release. |
|
Original automatic resulting-main qualification is complete for merge Build 42108617400, attempt 1 succeeded: 20 jobs succeeded and three PR-only jobs were declared skips. No rerun or extra full dispatch was used.
The canonical source file is now available at the immutable merge: 23,045 bytes / 64 IDs / SHA-256 Workflow owns normal incorporated-branch cleanup and the next concrete source/publication packet. No tag, release, installed/native experiment or consumer operation was performed by this qualification. |



The shared command-receipt work has no consumable typed-intent fixture. This adds source vectors derived from Core's existing
CommandIntentbehavior, with an executable unit test that reads all 64 case IDs: 38 values, 19 command digests and seven native request-root mappings, plus 12 digest equality/distinction relations.The fixture preserves signed 64-bit values, binary64 bits including negative zero, bytes/text, array/map identity, byte-sorted map keys, Unicode normalization distinctions and explicit run targeting. It marks non-finite and protected-marker conventions separately from supported native input. The source mapping documents native outer-map argument projection, without claiming native adapter execution.
No runtime implementation, receipt schema, capability, external-payload authority or publication changes. Server owns the companion admission/retention/concurrency/read-later consequences; this draft gives that review an actual candidate identity. The artifact remains a proposed source contract until the backend mappings and ordinary checks are reconciled.
Validation: JSON/unique-ID, credential/local-path and public-boundary checks pass; fresh ordinary CI pending. No full/manual, native or installed run. Integration remains behind the existing #1036/#1047 source train.
Refs durable-workflow/.github#216, durable-workflow/server#934, durable-workflow/cli#60.