Repository navigation
Run the PostgreSQL feature suite on pull requests - #1098
Merged
Merged
Conversation
PR CI ran four smoke tests plus changed feature files, so a feature test could pass a PR and fail only on main, as #870 did (#1095). The six-shard PostgreSQL feature matrix, which collects no coverage, now also runs on pull requests and the build gate requires it there. MySQL keeps the coverage shards on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Measured on this PR's first run, build 43122841981: PostgreSQL feature shards took 5.0–7.5 min (shards 0–5: 5.9, 6.8, 7.5, 5.0, 5.5, 6.2). That is under The first run also failed the central action policy, which requires PR jobs to skip the Composer cache for fork PRs. The PostgreSQL cache step now carries the same fork guard |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1095.
PR CI ran four smoke methods plus feature files the PR changed (120 s budget), so about 157 of 161 feature files ran only on
main. That is how #1092 broke main today. #1082 closed the same gap for the unit suite.Change: the existing six-shard
feature-postgresqlmatrix now runs on pull requests too, with the same services, env and splitter. Thebuildgate requires it on PRs (success, notskipped). It collects no coverage, so it's the cheap database matrix to run per PR. MySQL keeps the coverage-collecting shards and MariaDB stays on main.verify-feature-shards.phpandtest-build-routing.py(23 tests) are updated and pass locally.Cost: six more runners per PR. Today's main run had PostgreSQL shards at 7–9 minutes, under
pr-unit's ~12, so PR wall time shouldn't grow. This PR's own run measures it, and I'll post the numbers here before marking it ready. #1096 (#1097) already fixed the SQLite retry test flake that would otherwise have hit every PR.🤖 Generated with Claude Code