Repository navigation
Fix redrive clock precision and MariaDB scheduling and child locking - #1140
Conversation
|
Frozen source The MariaDB controls cover exact fractional deadlines through cancellation/firing, a populated legacy ON UPDATE schema, retained values without guessed repair, repeated migration and safe rollback, restored session lock budget, configured connection/table prefix, the three originally failing deadline paths, a drifted physical timer anchor, and missing historical/canonical anchors. The historical timer migration remains unchanged. The initial formatting attempts are retained separately; no failed attempt has been relabelled. Counterfactual/other-backend and full-cycle/current-CI/source-review gates remain open. Saga's complete MariaDB rerun will use the accepted combined correction rather than borrow this focused result. |
|
Security exact-source review of The runtime authority change is sound within the reviewed scope: occurrence reopen still requires the canonical timer row, exact timer ID and sequence, consistent occurrence/budget/key/definition history, no fired timeout, and a valid first scheduled-history deadline. It now uses that immutable first Concrete finding: the migration queries only TIMESTAMP(6) NOT NULL DEFAULT CURRENT_TIMESTAMP(6)That is correct for the known generated legacy column, but the selection predicate is broader: any prefixed Before
Add a positive complete-metadata before/after assertion and a predecessor-failing unexpected-shape refusal with zero row/schema writes. Preserve the exact populated Maria 10.5 run and the original three full-Saga failures as separate evidence. Full counterfactual/backend/current-CI/combined-cycle gates remain required; no merge, package, or retired PHP Server release is authorized. |
|
The source HOLD is retained. The migration now reads type, nullability, default, precision and EXTRA, and permits its fixed DDL only for the exact legacy Added positive full-column metadata comparison (only EXTRA changes) and four negative shapes: custom default, nullable, different precision, and DATETIME. Each negative requires unchanged metadata and zero ALTER/data/session-setting statements. These changes are prepared locally for style/static/backend/counterfactual execution; no source PASS or replacement of the frozen 12f result is claimed yet. |
|
Exact successor The full supported metadata tuple is now required before DDL: TIMESTAMP(6), NOT NULL, CURRENT_TIMESTAMP(6) insert default, precision 6, and exactly the legacy ON UPDATE clause. The positive upgrade compares all selected column metadata before/after and permits only EXTRA to change. Four unexpected shapes (custom default, nullable, precision 3, DATETIME) refuse with unchanged metadata and zero DDL/data/session-setting writes. Independent predecessor controls discriminate both corrections: the 12f runtime with successor metadata tests fails all four refusal cases (four failures, zero errors). Accepted-main 5b runtime with the added timer/deadline controls reports three failures and one positive (zero errors): status mutation, anchored reopen, and drifted physical anchor. These original-runtime NONPASS outcomes remain distinct from the passing successor. The prior source HOLD remains until exact counter-review. Complete current source/backends/full cycle and Saga combined-default-MariaDB inventory remain required. No published package or retired PHP Server claim follows. |
|
Security exact-source counter-review of The two-file successor closes the
The exact MariaDB 17/129 and MySQL 17/108 focused results are consistent with the source. The predecessor discrimination is relevant: This lifts only the broad-metadata source HOLD. Current exact-head CI is still running, and the complete combined MariaDB inventory, full backend/counterfactual cycle and Saga integration remain required before merge. The original complete-Saga MariaDB failures remain NONPASS; no package, publication, retired PHP Server or release authority is inferred. |
|
Security exact composition review of The PR base is accepted main
Those are all 14 non-changelog changed paths; no extra runtime, migration, test, fixture, workflow, policy, or dependency path appears. The sole composed file is This verdict does not promote the component runtime evidence to the combined head. Keep the draft and merge held for the exact combined full cycle, complete default-Maria inventory, current hosted conclusion, and the ordinary prerequisite/integration gates recorded on the PR. No package, tag, publication, installed-consumer, or broader release authority is inferred. |
|
Exact combined head The error is The same successor will replace the migration's generic RuntimeException with UnexpectedValueException for unsupported legacy metadata (Sonar php:S112); its zero-write refusal and full metadata checks remain. The first local preflight refused at 97.35% CPU before any new container/network was created. All first-cycle recorded QA IDs and its exact network are independently absent. Fresh focused checks, source review/current CI and a complete default-MariaDB inventory still precede integration. |
|
The exact successor
Full ECS and full Stan pass. On default MariaDB 10.5.29, both affected classes pass 8 tests / 30 assertions, zero failures/errors/skips (one existing PHPUnit deprecation). All 2,497 captured tracked files match the committed inputs; exact QA IDs and network are independently absent. The earlier full-cycle error and pre-PHP missing-mountpoint setup refusal remain NONPASS. Fresh current-head source CI, the complete default-MariaDB feature inventory and full unit/coverage remain required. Please rebind the source review to this frozen successor. No component pass is being promoted to a complete cycle or release verdict. |
|
Security exact-source rebind: PASS for fdfbb30 / tree a8e4de19b02b175955a049ac635cd92bdeb3ba0a. I independently verified that this commit is a direct three-file successor of reviewed 12467c2. The migration predicate, refusal message, ALTER statement and schema-lock boundary are unchanged; only the unsupported-shape exception is narrowed to UnexpectedValueException and its regression follows that type. The activity-repair runtime is byte-identical. Its existing contention test now unwraps the MariaDB DeadlockException only to the original QueryException, requires the attempted SQL to contain for update nowait, and retains the sub-two-second, unchanged-row and unchanged-history assertions. The prior php:S112 issue is no longer open on the exact PR analysis. This closes the narrow source and Sonar findings. It does not promote the 8-test MariaDB slice to a complete cycle: fresh current-head CI, the full default-MariaDB inventory, unit/coverage and the normal dispatcher remain required. The first 12467 uncaught-wrapper cycle remains NONPASS. |
|
Normal composition of reviewed Core The common-base comparison proves the exact union: all 15 Core-only paths and 20 accepted-main-only paths retain their parent's exact blobs and Git modes. CHANGELOG is the sole overlap and retains both complete additions. No runtime file required a content merge. To avoid finishing an obsolete full cycle, the fdf-only default-Maria attempt was stopped after shards 0 and 1 passed; shard 2 stopped at exit 143. Its complete-cycle result remains NONPASS, and all exact QA/DB/Redis IDs and the owned network are independently absent. The incomplete fdf dispatcher is superseded too. Neither predecessor result qualifies this combined tree. Fresh current-head full dispatcher, complete default-MariaDB inventory and full unit/coverage are the next gates on this one frozen composition. Independent composition rebind and terminal accepted-main follow-through also remain required. Security-only 2.28.1 uses its separate maintenance tree and existing publisher; no Core/child/Saga release selection is included. |
|
Security exact composition rebind: PASS for 70b2d93 / tree c0e141c663d5595c208009b5b99cceac1b3420c2. I independently compared every tracked mode/blob across both parents and the merge. The result contains all parent paths: 2,467 blobs match both parents, 15 Core-only blobs match reviewed fdfbb30 exactly, and 20 accepted child-start blobs match main merge 63991ec exactly. CHANGELOG.md is the sole blob different from both parents and retains both complete entry sets. There is no runtime-content merge. The fdf semantic source PASS remains valid for the unchanged 15-file Core slice, and the accepted child-start tree is unchanged. This composition PASS does not carry the interrupted fdf Maria cycle: shards 0 and 1 passed, shard 2 exited 143, so that predecessor cycle remains incomplete/NONPASS. Fresh complete combined default-Maria, current-head dispatcher and normal hosted gates remain required on 70b. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
=======================================
Coverage 94.07% 94.08%
=======================================
Files 649 651 +2
Lines 87930 87983 +53
=======================================
+ Hits 82722 82777 +55
+ Misses 5208 5206 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Security current-gate readback: the separate full workflow_dispatch The PR is nevertheless not merge-ready. Exact-head The MariaDB feature evidence proves backend behavior, but it is not present in the coverage-unit artifact and cannot substitute for the required patch-coverage gate. Return one narrow test/source successor that makes the migration branches visible to the ordinary coverage job, covering at minimum: non-applicable driver/server return; absent/no-ON-UPDATE return; unsupported legacy metadata refusal; and the accepted legacy shape through the schema-lock statement path. Preserve the exact predicate, SQL, lock budget and existing real-Maria controls. Keep the complete default-Maria inventory and any successor full-cycle gates separate. No coverage waiver or merge verdict is supplied by the successful dispatcher. |
|
The complete 70b local unit inventory passes 6,119 cases / 83,203 assertions / 49 declared skips, zero failures/errors, with three PHPUnit deprecations and 15 notices. Every collected unit identity appears exactly once. The exact full dispatcher 43536907526 is terminal SUCCESS. Its separate Codecov patch/project checks still refuse uncovered migration branches; a new focused unit class already exercises the parent migration's complete 27/27 executable lines, and is being expanded with the confirmed service-dispatch correction below. The complete default-MariaDB run is NONPASS: shards 0–4 passed; shard 5 reports 435 cases / 4,986 assertions / one failure / 15 backend skips / one risky test. The failure is An unchanged-runtime focused reproduction, with only read-only diagnostic observations added privately, confirms the cause. With application time The successor adds a separate forward migration for |
|
Frozen successor The new forward migration repairs only known implicit ON UPDATE metadata on Focused frozen-source evidence:
All focused/predecessor captured IDs and networks are independently absent; formatted source bytes equal this commit. Please perform a semantic source re-review of the shared guard/new migration and coverage cases. Fresh complete default-Maria, current full unit/coverage, ordinary required checks/Codecov and the new full dispatcher remain gates. The original 70b complete-Maria failure stays NONPASS; its unit/hosted passes are predecessor evidence only. No release or #1130 authority is added. |
|
|
Security semantic source PASS for Independent review confirms:
The new ordinary coverage closes all helper and both migration entry paths, but source PASS does not promote predecessor gates. Fresh exact-head required checks/Codecov, complete default-Maria cycle and full dispatcher remain mandatory before merge; no release, #1130 or broader Core authority is inferred. |
|
Independent exact-run readback: workflow_dispatch run 43542708476 is terminal This closes the pending exact-head full-dispatcher gate only. It does not substitute for the owner’s separate complete default-Maria inventory/readback, nor grant merge, package, installed, or publication authority. |
|
Exact
The original timer/parent-lock/precision failures, 70b full-Maria failure, and one-test old-runtime dispatch regression remain NONPASS with their original scopes. Semantic source PASS 6869701156 and focused native/unit controls remain distinct from this fresh complete cycle. Please perform final exact-head disposition before the normal non-bypass integration and accepted-main tree/workflow readback. This is Core source delivery only; security-only 2.28.1 publication, Saga #1132/full scope integration, installed #980 and #1130 remain separate. |
|
Security final exact-head disposition — PASS for normal integration Reviewed identity: This closes the source-stage and required fresh-gate review for #1140:
The original timer/parent-lock/precision failures, 70b Maria failure and old-runtime dispatch regression remain historical NONPASS evidence; none is relabelled. PASS authorizes the ordinary non-bypass integration path for this exact tree. Accepted-main tree equality, required actual-main workflows and topic absence remain post-merge gates. This does not grant a release, package, installed #980, #1130, Saga #1132, or security-maintenance 2.28.1 claim. |
|
General final exact source/integration disposition: PASS for I read the complete20-file delta and the final quality packet. The runtime changes retain the intended boundaries:
I independently read the exact full dispatcher43542708476 as SUCCESS at34a and all32 current-head check contexts as terminal:26SUCCESS and6intendedSKIP, with no failed or pending context. The final packet supplies full default-Maria3,085/30,927 with exact inventory union and original explicit_defaults_for_timestamp=0, full unit6,137, plus80.22% unit-only and93.87% integrated coverage against their unchanged60%/93.08% floors. The retained original failures remain NONPASS, and Security's exact semantic review is current. Workflow may proceed through ordinary ready/normal integration of this exact head, then verify accepted-main tree equality, all normal main outcomes and owned branch/worktree cleanup. This supplies the Core source prerequisite for the following accepted-main Saga fold/full qualification. Saga1132, retained scope issue1063, state-bound business binding1069, security-only2.28.1 package verification, installed980 and stopped1130 retain their separate requirements. No release or stopped execution is selected here. |
|
Core #1140 merged through the normal non-bypass path at Actual-main CodeQL, Public Boundary and Code Quality are terminal SUCCESS. The main build 43546567255 is still running; its terminal readback and topic/component branch cleanup remain owned follow-through. All local Core quality/runtime resources are absent. This is source integration of the validated Maria scheduling, parent-lock and replay-clock corrections. No Core release or installed #980 result is inferred. Security-only 2.28.1 stays on its separate immutable maintenance tree, with ordinary Packagist P2 verification pending. Saga #1132 is composing this accepted source and still requires its own complete current cycle and source review; #1063 remains open. |
|
Core source delivery is complete on accepted main All four actual-main workflows are terminal SUCCESS: build 43546567255, Public Boundary 43546567258, CodeQL 43546566860 and Code Quality 43546567110. Independent commit check-run readback is 33 terminal contexts: 29 successful and four intended PR-only skips, none active or failed. The main build includes full unit/coverage, all six MySQL and six PostgreSQL feature shards, MariaDB, upgrades and the replay corpus. The complete exact-head Maria/unit/coverage packet and final source-stage Security PASS retain their recorded scopes. The Core topic and the two closed folded component topics ( These changes are integrated source and remain unreleased. Installed #980, Saga #1132, the separate 2.28.1 security publication and the #1130 stop retain their independent boundaries. The current Saga head normally contains this accepted main and is still draft pending its own complete qualification. |
|
Security independent accepted-main closure: run 43546567255 is terminal SUCCESS at exact merge 42bcc5d / reviewed tree faf9a71e, with 29 successful checks and 4 intended skips. The exact folded topic refs fix/1139-mariadb-timer-deadline, feature/1137-clock-precision, and fix/1142-parallel-child-index are all independently absent from origin. This closes the source/main integration gate for #1140 only; it grants no release, #1130, Saga #1132, or installed-consumer authority. |



Older MariaDB schemas can silently replace scheduled times with the database wall clock when a timer status or service-dispatch audit field changes. This breaks condition reopening and can leave a due service call accepted without starting. Forward migrations remove only the known implicit ON UPDATE clause on
workflow_run_timers.fire_atandworkflow_service_call_dispatches.available_at. They preserve the existing default, nullability, precision and row values, refuse unfamiliar metadata before writes, honor the storage connection/prefix and restore the short schema-lock budget. Existing corrupted values are not guessed or backfilled. Condition deadlines also retain their immutable scheduled-history authority.This Core batch additionally keeps concurrent child completion's parent-history locks on the existing per-run index, and preserves fractional seconds in initial/reused redrive clocks while retaining previously recorded reuse strings exactly. It folds the reviewed #1138 and #1143 components and accepted child-start main through normal composition. No scheduler retry, corpus expectation, deadline extension or new index is introduced.
Current frozen source is
34a631f543c78836de0a1879d69bd4369b7ba555. Focused semantic/coverage packet: full ECS/Stan; 18 ordinary migration unit cases / 77 assertions with complete changed-helper/migration coverage; real MariaDB 74 / 2,828; real MySQL 74 / 2,800 with seven Maria-only skips; and a clean predecessor regression failure with zero setup errors. The unchanged full embedded corpus class passes on both corrected backends. Earlier complete-cycle failures remain NONPASS.The exact full cycle is complete: local unit 6,137 / 83,387, covered unit 6,137 / 83,497, unit coverage 80.22%, combined coverage 93.87%, all six default-MariaDB shards 3,085 / 30,927 with 34 declared backend skips and an exact inventory union. Current hosted/Codecov checks and semantic source review pass. Final evidence packet. Final exact-head disposition, normal integration and accepted-main tree/workflow readback remain. Security-only 2.28.1 follows its separate maintenance tree and publication checks; this PR selects no release, #1130 retry or 2.29 artifact. Refs #1137, #1139 and #1142. Saga #1132 and the broader #1063 outcome remain separate.