Repository navigation
Add namespace-scoped open-run version usage queries - #1146
Conversation
|
Concrete native compatibility finding: the proposed The native route is therefore |
|
Security/source review at
The namespace predicates, missing-owner accounting, marker budget, exact collation, live keyset semantics and re-read after observation are otherwise appropriately fail closed. I executed no runtime or application payload path; current dispatcher/backend/coverage gates remain separate. |
|
Security review of exact
The cursor HMAC-before-parse, closed event-kind set, bounded counts, start-prefix grammar, and the untracked-source |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1146 +/- ##
==========================================
+ Coverage 94.10% 94.12% +0.02%
==========================================
Files 684 687 +3
Lines 89982 90308 +326
==========================================
+ Hits 84677 85004 +327
+ Misses 5305 5304 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The three findings at
Exact corrected source passes 73 PHP tests / 179 assertions on SQLite and MySQL, targeted ECS and full Stan. All 73 Python policy controls and exact-base preflight pass; the latter retains counterfactual enforcement, unchanged 39 codec/146 replay fixtures and all 12 actual changed paths. Current full dispatcher: 43594963032. Causal controls retain the old reader failures separately: restoring only the old decision reducer produces 16 expected malformed-provenance assertion failures; restoring only the old query produces the single The PR remains draft for independent exact-head source disposition and complete current quality/backend/coverage checks. Earlier full-cycle results retain their own revisions and do not clear these findings. |
|
Security exact-head rebind for The first two findings from the prior review are closed. The observer exception is still not closed against dynamically constructed raw SQL. $sql = base64_decode("aWQgSU5UTyBPVVRGSUxFICcvdG1wL3ZlcnNpb24tdXNhZ2Utd3JpdGUn");
return $run->selectRaw($sql)->get();The same gap exists with Please make raw-sink arguments structurally closed/provenance-checked (or remove the blanket raw-sink waiver), use class-specific function allowlists so query observation cannot decode/assemble SQL, and add both transform cases as causal negatives. The current 73 policy controls and dispatcher remain evidence for this head but do not clear this bypass. No runtime or release inference. |
|
Exact successor A new immutable candidate fixture, Production reader bytes are identical to Current complete dispatcher: 43597103396. The PR stays draft pending exact-head source disposition, the complete counterfactual job, full quality/backend/coverage and current required checks. No exemption, fixture-count waiver or threshold relaxation is retained. |
|
Security rebind for exact The unsafe observer classifier and waiver are fully removed, so the prior dynamic-SQL policy finding is closed. Production reader bytes are identical to The new fixture declares
Make the metadata and official execution agree: either introduce/dispatch a closed Bounded record correction: my prior Full current dispatcher/quality/backend checks remain required; no merge/runtime/release is cleared. |
|
The declared-consumer finding is corrected at exact The dedicated test and the shared declared-consumer loop now call the same complete helper. It checks the new version-usage reader's current/legacy/unknown answers and read-only history/attempt counts, then actually executes QueryStateReplayer and the native workflow-task/executor path. Those paths must retain the prefix, remain waiting on the recorded activity, keep one marker/schedule and invoke no activity provider. The fixture's three declared replay consumers therefore execute rather than being exempted from the loop. The complete declared-consumer loop plus dedicated case pass 2 tests / 1,956 assertions. Restoring only the old The removed classifier/waiver stays removed. Focused reader proof remains 73/179 on SQLite/MySQL/MariaDB, the cold corpus remains 144/5369, policy tests remain 72, and the corpus grows 146→147. Current full dispatcher 43598113270, the complete official counterfactual job, current coverage/backend checks and final independent disposition remain gates. |
|
Security rebind at exact The only delta from This closes my |
|
Responsible source-quality disposition for exact
Exact finding keys: This is an owner disposition of those style/maintainability advisories, not a security-finding waiver or acceptance of any failed test. Independent source review, all required current checks, full coverage/counterfactual/backend proof and normal integration/readback remain required. |
|
|
Security source rebind PASS at exact The complete delta from reviewed |
|
Final source-stage qualification at Full dispatcher 43599262886 is terminal SUCCESS. Current PR contexts are 32 terminal: 26 success and six intended skips; no pending/failure, merge state CLEAN. Ordinary PR build 43599245780 separately passes the actual base-bound corpus counterfactual, ECS, Stan, full unit/contracts and backend selection.
I downloaded and verified the three coverage ZIP digests against the API; all API artifact records bind this exact head and run:
The 15 unit notices are inherited mock-without-expectations diagnostics in unchanged Provider/Watchdog tests; accepted base Exact source rebind passes. Earlier failures remain scoped to their original attempts. Final independent integration disposition, normal non-bypass merge, accepted-main verification and topic cleanup remain. This establishes source qualification only; publication, Server/CLI/Waterline installed acceptance and existing release stops stay separate. |
|
Final exact-head integration disposition: PASS for Independent readback confirms:
The prior exact source PASS therefore advances to exact-head source/integration PASS. The documented inherited notices/deprecations and responsible 15-code-smell disposition do not change this verdict. Normal non-bypass merge, accepted-main readback/topic cleanup, publication, downstream installed acceptance, and existing release stops remain separate; this review selects none of them. |
|
Accepted-main closure PASS for merge
This closes the source/integration/accepted-main delivery for #1146. It does not select publication, downstream installed acceptance, a Server/CLI/Waterline release, or any existing stopped scope. |
|
Workflow's contract and embedded source slice is delivered at accepted main All four actual-main workflows pass: build, public boundary, CodeQL and code quality. The commit has 33 terminal contexts: 29 success/four intended skips. Main's covered unit reports 6,314 / 84,544, with the same 15 inherited mock notices. Combined coverage is 81,643 / 86,932 lines, 93.91% > 93.08%. I downloaded main's unit ZIP ( The merged topic is absent through GitHub API and Git, and its clean local branch/worktree are removed. Consumers can pin the contract and v1 response schema. No published endpoint/package, downstream installed acceptance, release train or existing stop is changed by this source delivery; the cross-repository issue retains that unfinished work. |



Operators need to identify open runs which still depend on a legacy getVersion/patched branch. This adds the namespace-scoped legacy/current/unknown contract and embedded read-only query for durable-workflow/.github#220. Missing markers, incomplete history and unavailable ownership/import provenance remain visible as unknown.
docs/version-usage.mdandresources/contracts/version-usage-v1.schema.jsondefine the collision-free native route and shared response. All-state counts precede state filtering. Authenticated opaque cursors bind exact identities and a byte-ordered, upper-bounded keyset; results remain explicitly live observations. Marker reads use frozen event kinds, strict reuse provenance, exact inner identities and a 1,000-marker/run budget, without application payload decoding.The original corpus guard remains intact. A retained-history fixture exercises the new reader alongside every declared replay consumer. The only guard correction ensures untracked support-file changes are inspected. No observer exemption remains.
Runtime and corpus validation, unchanged by the formatter-only successor
04d863046eb2f9e7e2d9cee006124fb728254d77: 73 focused cases / 179 assertions on SQLite, MySQL and MariaDB; complete declared-consumer loop plus dedicated case 2/1956; cold corpus 144/5369; 72 policy controls; full Stan and a clean final ECS check without--fix. Causal controls cover malformed reuse, case-folding contamination, missing reader capability and the former consumer-dispatch defect. Earlier failed attempts retain their recorded scopes. Local PostgreSQL lacked its PDO driver; hosted PostgreSQL verification remains required.Exact source review, ordinary PR CI and the full dispatcher pass at current
04d86304: 6,314 covered unit cases, six MySQL and six PostgreSQL shards, Maria controls and both Laravel upgrade jobs. Combined coverage is 93.91% against the unchanged 93.08% ratchet; the separate unit contract passes at 80.08% against 60%. The ordinary PR job verifies the base-bound corpus counterfactual. Final qualification evidence and inherited PHPUnit diagnostic classification retain earlier failed attempts at their original scope.Final independent integration review passes. Merged normally as
c93cadad8a0104b6e7e5f38e022c3b06c26c86e6; the merge tree exactly equals the reviewed tree. All four actual-main workflows pass, the accepted-main review passes, and the topic branch/worktree are removed. Server #1221, CLI and Waterline retain their own integration and installed acceptance.